search

jspm / registry

The jspm registry and package.json override service
https://jspm.io
229 stars 256 forks source link

add override for material-design-lite #964

Closed gheoan closed 7 years ago

gheoan commented 7 years ago

material-design-lite's main field is not recognized from github endpoint.

guybedford commented 7 years ago

The alternative here would be to add a "main" field in the override for the material-light on github.

It may be better to use the github version as that will typically install less unnecessary dependencies in jspm.

Perhaps have a look at that and let me know if you're sure you still want to do this?

//cc @truongminh

gheoan commented 7 years ago

Right, I noticed that installing from the npm endpoint took longer because two additional dependencies were installed. I will change this pull request to override the main field.

gheoan commented 7 years ago

PR is ready.

truongminh commented 7 years ago

That is right! thank @Gheoan

gheoan commented 7 years ago

I corrected the path to the main file. guybedford see me comment here about minified file.

guybedford commented 7 years ago

@Gheoan because in development source maps still don't provide as a good of a debugging experience as having the original sources due to quirks of the source maps format. See http://fitzgeraldnick.com/2015/06/19/source-maps-are-insufficient.html for more info.

gheoan commented 7 years ago

Did the changes suggested by @guybedford. Ready for merge.

guybedford commented 7 years ago

👍