search

jspreadsheet / ce

Jspreadsheet is a lightweight vanilla javascript plugin to create amazing web-based interactive tables and spreadsheets compatible with other spreadsheet software.
https://bossanova.uk/jspreadsheet/v4
MIT License
6.66k stars 820 forks source link

References to "jspreadsheet" instead of "jexcel" in the code #1603

Closed gtasker10 closed 1 year ago

gtasker10 commented 1 year ago

A recent commit put references to "jspreadsheet" instead of "jexcel" in the code that checks if the spacebar was pressed to start edition

// Characters able to start a edition if (e.keyCode == 32) { // Space e.preventDefault() if (jspreadsheet.current.options.columns[columnId].type == 'checkbox' || jspreadsheet.current.options.columns[columnId].type == 'radio') { jspreadsheet.current.setCheckRadioValue(); } else { // Start edition jspreadsheet.current.openEditor(jspreadsheet.current.records[rowId][columnId], true); } } else if (e.keyCode == 113) {

stephanestermann commented 1 year ago

Jexcel has been renamed to Jspreadsheet. https://github.com/jspreadsheet/ce/releases/tag/v4.6.0

gtasker10 commented 1 year ago

@stephanestermann The code had mistakenly replaced "jexcel" with "jspreadsheet" on 5 lines causing an exception to be thrown any time focus was on a radio or checkbox element and the user pressed the spacebar. The code all still references "jexcel". Only the name of the library changed