Closed yhay81 closed 3 months ago
Hello @hodeware and @giko45,
I've initiated this PR echoing the valuable effort behind @giko45's #594, focusing on a vital feature for me. I'm fully prepared to make any required updates to align with the project's current needs.
@Giko45, your foundational work is deeply appreciated. If you're still passionate about this feature and willing, your support in engaging with @hodeware would mean a lot.
Hi @yhay81, thanks a lot. I would be happy to review your PR. There is one change required.
The method signature should stay the same. The compatibility with all versions and distributions are very important. obj.paste = function(x, y, data);
Solution: it seems you need the selection range inside the paste, you can use the following property which is already available on the scope of the function. obj.selectedCell
It would be great if you can commit those changes, so we can proceed with the merge.
Hi @yhay81,
Happy it comes into use :).
I don't have the code readly available but try as @hodeware suggest: just change your extra line to:
selectedCell = obj.selectedCell.map((cell) => parseInt(cell));
and rollback all jexcel.current.paste calls.
Thanks, we are reviewing the PR soon.
@hodeware, @giko45 Thank you for the feedback. I've made the changes using obj.selectedCell and committed them!
Thanks
Hello,
I've opened a PR same as https://github.com/jspreadsheet/ce/pull/594, targeting a feature I believe is crucial. Eager to contribute more, I welcome any guidance on how I can assist further with this feature or elsewhere in the project.
Your feedback would be greatly appreciated. Thank you for your hard work on this project!