search

jspreadsheet / pro

Jspreadsheet Pro | The javascript spreadsheet
https://jspreadsheet.com/
15 stars 1 forks source link

Delete row - undo - redo - crash #306

Closed dmt0 closed 10 months ago

dmt0 commented 10 months ago

Could reproduce in the example here: https://jspreadsheet.com/docs/history

Scenario: Populate 3 rows

image

delete row 2 delete row 3 undo undo redo - crash with JS error

index.min.js:203 Uncaught TypeError: Cannot read properties of null (reading 'length')
    at Object.g (index.min.js:203:197)
    at l.<computed> (index.min.js:206:277)
    at Object.p (index.min.js:91:52)
    at q.<computed> (index.min.js:93:425)
    at q.<computed> (index.min.js:93:509)
    at Object.h (index.min.js:320:274)
    at e.<computed> [as deleteRow] (index.min.js:329:177)
    at h (index.min.js:136:147)
    at e.<computed> [as redo] (index.min.js:141:266)
    at HTMLInputElement.onclick (history:386:115)
hodeware commented 10 months ago

Thanks. There is a patch to available on NPM tonight.

VirendraMaheta7 commented 4 months ago

@hodeware Hi, I am getting the same error while deleting column. image I am using jspreadsheet version - "jspreadsheet": "^10.5.3". Angular version - "@angular/core": "^14.2.4"