jspricke / ros-deb-builder-action

Github Action to convert ROS packages to Debian packages
BSD 3-Clause "New" or "Revised" License
65 stars 24 forks source link

Add -y to add-apt-repository #2

Closed esteve closed 1 year ago

esteve commented 1 year ago

This is useful when running this action via https://github.com/nektos/act to avoid add-apt-repository prompting for confirmation

jspricke commented 1 year ago

Thx and thanks for testing this, feel free to ask if you get stuck. Btw. you can also run the scripts on a normal Debian testing system without the PPA.

jspricke commented 1 year ago

@esteve btw. your current job is missing this: https://gitlab.com/autowarefoundation/autoware.auto/autoware_auto_msgs/-/commit/a85138f3f4adcece4fe46bef4ef344dde4a5923d

v4hn commented 1 year ago

@esteve Do you have it working with act already? I am currently setting up something with this as well, but am currently stuck on sbuild failing to setup the chroot environment.

Various other changes incoming though as well, I just need to get it to work and cleanup afterwards :)

esteve commented 1 year ago

@esteve btw. your current job is missing this: https://gitlab.com/autowarefoundation/autoware.auto/autoware_auto_msgs/-/commit/a85138f3f4adcece4fe46bef4ef344dde4a5923d

Good catch, thanks!

esteve commented 1 year ago

@esteve Do you have it working with act already? I am currently setting up something with this as well, but am currently stuck on sbuild failing to setup the chroot environment.

Not yet, I made some progress, but had to add a couple of hacks (missing /home/runner or not being writable)

jspricke commented 1 year ago

Just for completeness, I don't think it will work in ACT as sbuild needs user namespaces. On the other hand it should be easy to adopt the scripts to run on any Ubuntu 22.04 or Debian testing.