search

jspricke / ros-deb-builder-action

Github Action to convert ROS packages to Debian packages
BSD 3-Clause "New" or "Revised" License
65 stars 24 forks source link

Pipeline Ubuntu 20.04 and Noetic #28

Closed g-gemignani closed 1 year ago

g-gemignani commented 1 year ago

Hi @jspricke,

Thank you so much for this contribution! In the past few weeks, I was trying to package this repo https://github.com/aiplan4eu/UP4ROS, and I was now thinking to use your action. However, when I added it to the UP4ROS workflow I got this error:

Get:1 http://deb.debian.org/debian bullseye InRelease [116 kB] Err:1 http://deb.debian.org/debian bullseye InRelease The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 648ACFD622F3D138 NO_PUBKEY 0E98404D386FA1D9 NO_PUBKEY 605C66F00D6C9793 Reading package lists... W: GPG error: http://deb.debian.org/debian bullseye InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 648ACFD622F3D138 NO_PUBKEY 0E98404D386FA1D9 NO_PUBKEY 605C66F00D6C9793 E: The repository 'http://deb.debian.org/debian bullseye InRelease' is not signed.

Link to build: https://github.com/aiplan4eu/UP4ROS/actions/runs/4875405225/jobs/8697550216 Is this expected? Do I need to modify my workflow? Thank you! :smile:

jspricke commented 1 year ago

That does not look like the proposed yaml definition, can you try this one? https://github.com/jspricke/ros-deb-builder-action#example-usage

g-gemignani commented 1 year ago

Thank you for the quick answer. It doesn't look like the proposed yaml definition because I added it as an extra step of the workflow used to build and test the package. I now added it as a separate workflow to the repo: https://github.com/aiplan4eu/UP4ROS/blob/devel/.github/workflows/debian.yaml here is the result: https://github.com/aiplan4eu/UP4ROS/actions/runs/4978478905/jobs/8908841277 Thank you again for your support!

jspricke commented 1 year ago

The workflow needs 22.04 as the host VM here: https://github.com/aiplan4eu/UP4ROS/blob/devel/.github/workflows/debian.yaml#L13

g-gemignani commented 1 year ago

Yep, that was the deal. Now failing for other reasons. Thank you for the support!

g-gemignani commented 1 year ago

Never mind, here is the issue again: https://github.com/aiplan4eu/UP4ROS/actions/runs/4978675377/jobs/8909281587

jspricke commented 1 year ago

E: The repository 'http://packages.ros.org/ros/ubuntu bullseye Release' does not have a Release file.

There is no noetic distribution for bullseye. Either use a supported noetic distribution (buster or focal) or switch to the debian ROS_DISTRO ;).

g-gemignani commented 1 year ago

Ah clear! I thought that DEB_DISTRO meant the debian distro, and since focal is based on bullseye, that is why I added it. Now everything got solved. Thank you!

jspricke commented 1 year ago

DEB_DISTRO means in fact the Debian (or derivative) distribution but focal is not based on bullseye (it was rather branched of Debian unstable at some point but that's nothing apt knows about).

g-gemignani commented 1 year ago

Oh ok, I thought bullseye since this is what my computer with Ubuntu 20.04 was saying:

$ cat /etc/debian_version bullseye/sid

Good to know. Thanks again for the help!

jspricke commented 1 year ago

sid is the codename for unstable and and that time bullseye was the next version