Closed Timple closed 5 months ago
Invocation of command 'import' on client 'git' failed: AssertionError: Could not find 'git' executable (/usr/lib/python3/dist-packages/vcstool/clients/git.py:771)
Looks like zenoh_c_vendor
needs a <buildtool_depend>git</buildtool_depend>
. Also #38 is probably relevant.
Ah, sorry for being incomplete. I tried that already but forgot to mention it. If I run it from this branch, i get:
Could not determine ref type of version: fatal: unable to access 'https://github.com/eclipse-zenoh/zenoh-c.git/': Could not resolve host: github.com
Rerunning didn't help, so it's not a flaky thing. That's how I ended up here. I'm not sure if it should have internet access from these actions?
Please apply the workaround from #38.
Yes, thank you. This works much better. However...
-- Found zenoh_c_vendor: 0.0.1 (/opt/ros/iron/share/zenoh_c_vendor/cmake)
CMake Error at CMakeLists.txt:28 (find_package):
By not providing "Findzenohc.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "zenohc", but
CMake did not find one.
Could not find a package configuration file provided by "zenohc" with any
of the following names:
zenohcConfig.cmake
zenohc-config.cmake
Add the installation prefix of "zenohc" to CMAKE_PREFIX_PATH or set
"zenohc_DIR" to a directory containing one of the above files. If "zenohc"
provides a separate development package or SDK, be sure it has been
installed.
-- Configuring incomplete, errors occurred!
See also "/<<BUILDDIR>>package/obj-x86_64-linux-gnu/CMakeFiles/CMakeOutput.log".
cd obj-x86_64-linux-gnu && tail -v -n \+0 CMakeCache.txt
So rmw_zenoh_cpp
requires zenoh_c_vendor
which is somehow detected but the find_package
fails.
Although this might also be an issue with rmw_zenoh
. If you suspect this is the case, we can close this issue.
Sounds rather like a problem during the build of zenoh_c_vendor
. Can you post a link to the complete build log?
Certainly! Here you go
From the log:
2024-05-13T08:49:10.2230905Z -rw-r--r-- root/root 278 2024-05-13 08:41 ./opt/ros/iron/share/zenoh_c_vendor/cmake/vendor_package_cmake_prefix.cmake
2024-05-13T08:49:10.2232801Z -rw-r--r-- root/root 432 2024-05-13 08:41 ./opt/ros/iron/share/zenoh_c_vendor/cmake/zenoh_c_vendorConfig-version.cmake
2024-05-13T08:49:10.2234666Z -rw-r--r-- root/root 1337 2024-05-13 08:41 ./opt/ros/iron/share/zenoh_c_vendor/cmake/zenoh_c_vendorConfig.cmake
Whereas rmw_zenoh_cpp
searches for zenohc
here: https://github.com/ros2/rmw_zenoh/blob/rolling/rmw_zenoh_cpp/CMakeLists.txt#L28C16-L28C22
So either the build of zenoh_c_vendor
should somehow produce a zenohcConfig.cmake
(maybe ament could do that?) or rmw_zenoh_cpp
should depend on zenoh_c_vendor
rather.
But your second suggestion is already the case right? https://github.com/ros2/rmw_zenoh/blob/rolling/rmw_zenoh_cpp/package.xml#L12
That's only the build dependency, our problem is during cmake. Can you try with this line removed? https://github.com/ros2/rmw_zenoh/blob/rolling/rmw_zenoh_cpp/CMakeLists.txt#L28C16-L28C22
Then I get the same error as I get locally:
CMake Error at CMakeLists.txt:27 (add_library):
Target "rmw_zenoh_cpp" links to target "zenohc::lib" but the target was not
found. Perhaps a find_package() call is missing for an IMPORTED target, or
an ALIAS target is missing?
Can you push the logs to a more permanent place? Both logs seem to be expired now.
Ah, yes.
With git and network: https://github.com/nobleo/ros_debian_packages/actions/runs/9059879597/job/24888399609#step:2:5469
Without find_package(zenohc)
: https://github.com/nobleo/ros_debian_packages/actions/runs/9061173043/job/24892418445
Fix is here: https://github.com/eclipse-zenoh/zenoh-c/pull/358
You're awesome! That is not something I would have cooked up in a day...
Can you close it if there are no more issues?
Yup! Great
Thank you, all is merged and operational now. :+1:
Cannot release
rmw_zenoh
. Of course this might be an a-typical package as it uses rust. But just noting it here in case anyone has some insights.Seems to stall on a git clone.
Configuration:
Console output
``` +------------------------------------------------------------------------------+ | Build | +------------------------------------------------------------------------------+ Unpack source ------------- Format: 1.0 Source: ros-iron-zenoh-c-vendor Binary: ros-iron-zenoh-c-vendor Architecture: any Version: 0-2024.05.13.07.24 Maintainer: Yadunund