search

jspricke / ros-deb-builder-action

Github Action to convert ROS packages to Debian packages
BSD 3-Clause "New" or "Revised" License
65 stars 24 forks source link

Cannot release `rmw_zenoh` #49

Closed Timple closed 5 months ago

Timple commented 5 months ago

Cannot release rmw_zenoh. Of course this might be an a-typical package as it uses rust. But just noting it here in case anyone has some insights.

Seems to stall on a git clone.

Configuration:

repositories:
  rmw_zenoh:
    type: git
    url: https://github.com/ros2/rmw_zenoh
    version: rolling
Console output ``` +------------------------------------------------------------------------------+ | Build | +------------------------------------------------------------------------------+ Unpack source ------------- Format: 1.0 Source: ros-iron-zenoh-c-vendor Binary: ros-iron-zenoh-c-vendor Architecture: any Version: 0-2024.05.13.07.24 Maintainer: Yadunund Standards-Version: 3.9.2 Build-Depends: debhelper (>= 9.0.0), cargo, clang, ros-iron-ament-cmake, ros-iron-ament-cmake-vendor-package Package-List: ros-iron-zenoh-c-vendor deb misc optional arch=any Checksums-Sha1: 6ed48b704c28b657b9a3a7719ca7de49ac32298d 3083 ros-iron-zenoh-c-vendor_0-2024.05.13.07.24.tar.gz Checksums-Sha256: 646ecd896daf33f0c6c60e01506b48dd19ff792c42d632c94d67eec37ab944eb 3083 ros-iron-zenoh-c-vendor_0-2024.05.13.07.24.tar.gz Files: aa5751ea9addb142285a7dd9294f29f8 3083 ros-iron-zenoh-c-vendor_0-2024.05.13.07.24.tar.gz dpkg-source: warning: extracting unsigned source package (ros-iron-zenoh-c-vendor_0-2024.05.13.07.24.dsc) dpkg-source: info: extracting ros-iron-zenoh-c-vendor in /<>package dpkg-source: info: unpacking ros-iron-zenoh-c-vendor_0-2024.05.13.07.24.tar.gz Check disk space ---------------- Sufficient free space for build User Environment ---------------- APT_CONFIG=/var/lib/sbuild/apt.conf CCACHE_DIR=/build/ccache DEB_BUILD_OPTIONS=nocheck HOME=/var/lib/sbuild LANG=C.UTF-8 LC_ALL=C.UTF-8 LOGNAME=runner OLDPWD=/ PATH=/usr/lib/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games *** SHELL=/bin/sh USER=runner dpkg-buildpackage ----------------- Command: dpkg-buildpackage --sanitize-env -us -uc -b -rfakeroot dpkg-buildpackage: info: source package ros-iron-zenoh-c-vendor dpkg-buildpackage: info: source version 0-2024.05.13.07.24 dpkg-buildpackage: info: source distribution jammy dpkg-buildpackage: info: source changed by Yadunund dpkg-source --before-build . dpkg-buildpackage: info: host architecture amd64 dpkg-source: info: using options from package/debian/source/options: --auto-commit fakeroot debian/rules clean dh clean -v --buildsystem=cmake dh_auto_clean -O-v -O--buildsystem=cmake dh_autoreconf_clean -O-v -O--buildsystem=cmake dh_clean -O-v -O--buildsystem=cmake rm -f debian/debhelper-build-stamp rm -rf debian/.debhelper/ CMAKE_INSTALL_LOCALSTATEDIR CMAKE_INSTALL_RUNSTATEDIR CMAKE_INSTALL_SYSCONFDIR -- Build files have been written to: /<>package/obj-x86_64-linux-gnu make[1]: Leaving directory '/<>package' rm -f debian/ros-iron-zenoh-c-vendor.debhelper.log debian/rules override_dh_auto_build make[1]: Entering directory '/<>package' # In case we're installing to a non-standard location, look for a setup.sh # in the install tree and source it. It will set things like # CMAKE_PREFIX_PATH, PKG_CONFIG_PATH, and PYTHONPATH. if [ -f "/opt/ros/iron/setup.sh" ]; then . "/opt/ros/iron/setup.sh"; fi && \ dh_auto_build cd obj-x86_64-linux-gnu && make -j2 "INSTALL=install --strip-program=true" VERBOSE=1 make[2]: Entering directory '/<>package/obj-x86_64-linux-gnu' /usr/bin/cmake -S/<>package -B/<>package/obj-x86_64-linux-gnu --check-build-system CMakeFiles/Makefile.cmake 0 /usr/bin/cmake -E cmake_progress_start /<>package/obj-x86_64-linux-gnu/CMakeFiles /<>package/obj-x86_64-linux-gnu//CMakeFiles/progress.marks make -f CMakeFiles/Makefile2 all make[3]: Entering directory '/<>package/obj-x86_64-linux-gnu' make -f CMakeFiles/zenoh_c_vendor.dir/build.make CMakeFiles/zenoh_c_vendor.dir/depend make[4]: Entering directory '/<>package/obj-x86_64-linux-gnu' cd /<>package/obj-x86_64-linux-gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /<>package /<>package /<>package/obj-x86_64-linux-gnu /<>package/obj-x86_64-linux-gnu /<>package/obj-x86_64-linux-gnu/CMakeFiles/zenoh_c_vendor.dir/DependInfo.cmake --color= make[4]: Leaving directory '/<>package/obj-x86_64-linux-gnu' make -f CMakeFiles/zenoh_c_vendor.dir/build.make CMakeFiles/zenoh_c_vendor.dir/build make[4]: Entering directory '/<>package/obj-x86_64-linux-gnu' [ 14%] Creating directories for 'zenoh_c_vendor' /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src/zenoh_c_vendor /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src/zenoh_c_vendor-build /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/install /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/tmp /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src/zenoh_c_vendor-stamp /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src/zenoh_c_vendor-stamp /usr/bin/cmake -E touch /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src/zenoh_c_vendor-stamp/zenoh_c_vendor-mkdir [ 28%] Performing download step for 'zenoh_c_vendor' cd /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src && /usr/bin/vcs import . --input /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor.repos --shallow --recursive --force === ./zenoh_c_vendor (git) === Invocation of command 'import' on client 'git' failed: AssertionError: Could not find 'git' executable (/usr/lib/python3/dist-packages/vcstool/clients/git.py:771) make[4]: *** [CMakeFiles/zenoh_c_vendor.dir/build.make:101: zenoh_c_vendor-prefix/src/zenoh_c_vendor-stamp/zenoh_c_vendor-download] Error 1 make[4]: Leaving directory '/<>package/obj-x86_64-linux-gnu' make[3]: *** [CMakeFiles/Makefile2:140: CMakeFiles/zenoh_c_vendor.dir/all] Error 2 make[3]: Leaving directory '/<>package/obj-x86_64-linux-gnu' make[2]: *** [Makefile:149: all] Error 2 make[2]: Leaving directory '/<>package/obj-x86_64-linux-gnu' dh_auto_build: error: cd obj-x86_64-linux-gnu && make -j2 "INSTALL=install --strip-program=true" VERBOSE=1 returned exit code 2 make[1]: *** [debian/rules:38: override_dh_auto_build] Error 25 make[1]: Leaving directory '/<>package' make: *** [debian/rules:22: build] Error 2 dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 -------------------------------------------------------------------------------- Build finished at 2024-05-13T07:24:48Z Finished -------- ```
jspricke commented 5 months ago 
Invocation of command 'import' on client 'git' failed: AssertionError: Could not find 'git' executable (/usr/lib/python3/dist-packages/vcstool/clients/git.py:771)

Looks like zenoh_c_vendor needs a <buildtool_depend>git</buildtool_depend>. Also #38 is probably relevant.

Timple commented 5 months ago

Ah, sorry for being incomplete. I tried that already but forgot to mention it. If I run it from this branch, i get:

Could not determine ref type of version: fatal: unable to access 'https://github.com/eclipse-zenoh/zenoh-c.git/': Could not resolve host: github.com

Rerunning didn't help, so it's not a flaky thing. That's how I ended up here. I'm not sure if it should have internet access from these actions?

Console output ``` +------------------------------------------------------------------------------+ | Build | +------------------------------------------------------------------------------+ Unpack source ------------- Format: 1.0 Source: ros-iron-zenoh-c-vendor Binary: ros-iron-zenoh-c-vendor Architecture: any Version: 0-2024.05.12.14.47 Maintainer: Yadunund Standards-Version: 3.9.2 Build-Depends: debhelper (>= 9.0.0), cargo, clang, git, ros-iron-ament-cmake, ros-iron-ament-cmake-vendor-package Package-List: ros-iron-zenoh-c-vendor deb misc optional arch=any Checksums-Sha1: 1961f4ca2d4a89a30f50ba3d9790c070c0cd337a 3898 ros-iron-zenoh-c-vendor_0-2024.05.12.14.47.tar.gz Checksums-Sha256: fe93687ea7c3a556eb95c29d525f5db3e98791207c374a1124a5e1e6a9df0149 3898 ros-iron-zenoh-c-vendor_0-2024.05.12.14.47.tar.gz Files: 4a35f5b7d4918fa07478c566acb6f6bf 3898 ros-iron-zenoh-c-vendor_0-2024.05.12.14.47.tar.gz dpkg-source: warning: extracting unsigned source package (ros-iron-zenoh-c-vendor_0-2024.05.12.14.47.dsc) dpkg-source: info: extracting ros-iron-zenoh-c-vendor in /<>package dpkg-source: info: unpacking ros-iron-zenoh-c-vendor_0-2024.05.12.14.47.tar.gz Check disk space ---------------- Sufficient free space for build User Environment ---------------- APT_CONFIG=/var/lib/sbuild/apt.conf CCACHE_DIR=/build/ccache DEB_BUILD_OPTIONS=nocheck HOME=/var/lib/sbuild LANG=C.UTF-8 LC_ALL=C.UTF-8 LOGNAME=runner OLDPWD=/ PATH=/usr/lib/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games *** SHELL=/bin/sh USER=runner dpkg-buildpackage ----------------- Command: dpkg-buildpackage --sanitize-env -us -uc -b -rfakeroot dpkg-buildpackage: info: source package ros-iron-zenoh-c-vendor dpkg-buildpackage: info: source version 0-2024.05.12.14.47 dpkg-buildpackage: info: source distribution jammy dpkg-buildpackage: info: source changed by Yadunund dpkg-source --before-build . dpkg-buildpackage: info: host architecture amd64 dpkg-source: info: using options from package/debian/source/options: --auto-commit fakeroot debian/rules clean dh clean -v --buildsystem=cmake dh_auto_clean -O-v -O--buildsystem=cmake dh_autoreconf_clean -O-v -O--buildsystem=cmake dh_clean -O-v -O--buildsystem=cmake rm -f debian/debhelper-build-stamp rm -rf debian/.debhelper/ rm -f -- debian/ros-iron-zenoh-c-vendor.substvars debian/files rm -fr -- debian/ros-iron-zenoh-c-vendor/ debian/tmp/ find . \( \( \ \( -path .\*/.git -o -path .\*/.svn -o -path .\*/.bzr -o -path .\*/.hg -o -path .\*/CVS -o -path .\*/.pc -o -path .\*/_darcs \) -prune -o -type f -a \ \( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE \ -o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \ -o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \ -o -name TAGS -o \( -path '*/.deps/*' -a -name '*.P' \) \ \) -exec rm -f {} + \) -o \ \( -type d -a -name autom4te.cache -prune -exec rm -rf {} + \) \) debian/rules build dh build -v --buildsystem=cmake dh_update_autotools_config -O-v -O--buildsystem=cmake dh_autoreconf -O-v -O--buildsystem=cmake debian/rules override_dh_auto_configure make[1]: Entering directory '/<>package' # In case we're installing to a non-standard location, look for a setup.sh # in the install tree and source it. It will set things like # CMAKE_PREFIX_PATH, PKG_CONFIG_PATH, and PYTHONPATH. if [ -f "/opt/ros/iron/setup.sh" ]; then . "/opt/ros/iron/setup.sh"; fi && \ dh_auto_configure -- \ -DCMAKE_INSTALL_PREFIX="/opt/ros/iron" \ -DAMENT_PREFIX_PATH="/opt/ros/iron" \ -DCMAKE_PREFIX_PATH="/opt/ros/iron" install -d obj-x86_64-linux-gnu cd obj-x86_64-linux-gnu && cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_SYSCONFDIR=/etc -DCMAKE_INSTALL_LOCALSTATEDIR=/var -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_RUNSTATEDIR=/run "-GUnix Makefiles" -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_INSTALL_LIBDIR=lib/x86_64-linux-gnu -DCMAKE_INSTALL_PREFIX=/opt/ros/iron -DAMENT_PREFIX_PATH=/opt/ros/iron -DCMAKE_PREFIX_PATH=/opt/ros/iron .. -- The C compiler identification is GNU 11.4.0 -- The CXX compiler identification is GNU 11.4.0 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/lib/ccache/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/lib/ccache/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Found ament_cmake: 2.0.5 (/opt/ros/iron/share/ament_cmake/cmake) -- Found Python3: /usr/bin/python3.10 (found version "3.10.12") found components: Interpreter -- Found ament_cmake_vendor_package: 2.0.5 (/opt/ros/iron/share/ament_cmake_vendor_package/cmake) -- Configuring done -- Generating done CMake Warning: Manually-specified variables were not used by the project: AMENT_PREFIX_PATH CMAKE_EXPORT_NO_PACKAGE_REGISTRY CMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY CMAKE_INSTALL_LIBDIR CMAKE_INSTALL_LOCALSTATEDIR CMAKE_INSTALL_RUNSTATEDIR CMAKE_INSTALL_SYSCONFDIR -- Build files have been written to: /<>package/obj-x86_64-linux-gnu make[1]: Leaving directory '/<>package' rm -f debian/ros-iron-zenoh-c-vendor.debhelper.log debian/rules override_dh_auto_build make[1]: Entering directory '/<>package' # In case we're installing to a non-standard location, look for a setup.sh # in the install tree and source it. It will set things like # CMAKE_PREFIX_PATH, PKG_CONFIG_PATH, and PYTHONPATH. if [ -f "/opt/ros/iron/setup.sh" ]; then . "/opt/ros/iron/setup.sh"; fi && \ dh_auto_build cd obj-x86_64-linux-gnu && make -j2 "INSTALL=install --strip-program=true" VERBOSE=1 make[2]: Entering directory '/<>package/obj-x86_64-linux-gnu' /usr/bin/cmake -S/<>package -B/<>package/obj-x86_64-linux-gnu --check-build-system CMakeFiles/Makefile.cmake 0 /usr/bin/cmake -E cmake_progress_start /<>package/obj-x86_64-linux-gnu/CMakeFiles /<>package/obj-x86_64-linux-gnu//CMakeFiles/progress.marks make -f CMakeFiles/Makefile2 all make[3]: Entering directory '/<>package/obj-x86_64-linux-gnu' make -f CMakeFiles/zenoh_c_vendor.dir/build.make CMakeFiles/zenoh_c_vendor.dir/depend make[4]: Entering directory '/<>package/obj-x86_64-linux-gnu' cd /<>package/obj-x86_64-linux-gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /<>package /<>package /<>package/obj-x86_64-linux-gnu /<>package/obj-x86_64-linux-gnu /<>package/obj-x86_64-linux-gnu/CMakeFiles/zenoh_c_vendor.dir/DependInfo.cmake --color= make[4]: Leaving directory '/<>package/obj-x86_64-linux-gnu' make -f CMakeFiles/zenoh_c_vendor.dir/build.make CMakeFiles/zenoh_c_vendor.dir/build make[4]: Entering directory '/<>package/obj-x86_64-linux-gnu' [ 14%] Creating directories for 'zenoh_c_vendor' /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src/zenoh_c_vendor /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src/zenoh_c_vendor-build /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/install /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/tmp /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src/zenoh_c_vendor-stamp /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src /usr/bin/cmake -E make_directory /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src/zenoh_c_vendor-stamp /usr/bin/cmake -E touch /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src/zenoh_c_vendor-stamp/zenoh_c_vendor-mkdir [ 28%] Performing download step for 'zenoh_c_vendor' cd /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor-prefix/src && /usr/bin/vcs import . --input /<>package/obj-x86_64-linux-gnu/zenoh_c_vendor.repos --shallow --recursive --force === ./zenoh_c_vendor (git) === Could not determine ref type of version: fatal: unable to access 'https://github.com/eclipse-zenoh/zenoh-c.git/': Could not resolve host: github.com make[4]: *** [CMakeFiles/zenoh_c_vendor.dir/build.make:101: zenoh_c_vendor-prefix/src/zenoh_c_vendor-stamp/zenoh_c_vendor-download] Error 1 make[4]: Leaving directory '/<>package/obj-x86_64-linux-gnu' make[3]: *** [CMakeFiles/Makefile2:140: CMakeFiles/zenoh_c_vendor.dir/all] Error 2 make[3]: Leaving directory '/<>package/obj-x86_64-linux-gnu' make[2]: *** [Makefile:149: all] Error 2 make[2]: Leaving directory '/<>package/obj-x86_64-linux-gnu' dh_auto_build: error: cd obj-x86_64-linux-gnu && make -j2 "INSTALL=install --strip-program=true" VERBOSE=1 returned exit code 2 make[1]: *** [debian/rules:38: override_dh_auto_build] Error 25 make[1]: Leaving directory '/<>package' make: *** [debian/rules:22: build] Error 2 dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 -------------------------------------------------------------------------------- Build finished at 2024-05-12T14:48:17Z Finished -------- ```
jspricke commented 5 months ago

Please apply the workaround from #38.

Timple commented 5 months ago

Yes, thank you. This works much better. However...

-- Found zenoh_c_vendor: 0.0.1 (/opt/ros/iron/share/zenoh_c_vendor/cmake)
  CMake Error at CMakeLists.txt:28 (find_package):
    By not providing "Findzenohc.cmake" in CMAKE_MODULE_PATH this project has
    asked CMake to find a package configuration file provided by "zenohc", but
    CMake did not find one.
    Could not find a package configuration file provided by "zenohc" with any
    of the following names:
      zenohcConfig.cmake
      zenohc-config.cmake
    Add the installation prefix of "zenohc" to CMAKE_PREFIX_PATH or set
    "zenohc_DIR" to a directory containing one of the above files.  If "zenohc"
    provides a separate development package or SDK, be sure it has been
    installed.
  -- Configuring incomplete, errors occurred!
  See also "/<<BUILDDIR>>package/obj-x86_64-linux-gnu/CMakeFiles/CMakeOutput.log".
    cd obj-x86_64-linux-gnu && tail -v -n \+0 CMakeCache.txt

So rmw_zenoh_cpp requires zenoh_c_vendor which is somehow detected but the find_package fails.

Although this might also be an issue with rmw_zenoh. If you suspect this is the case, we can close this issue.

jspricke commented 5 months ago

Sounds rather like a problem during the build of zenoh_c_vendor. Can you post a link to the complete build log?

Timple commented 5 months ago

Certainly! Here you go

jspricke commented 5 months ago

From the log:

2024-05-13T08:49:10.2230905Z -rw-r--r-- root/root       278 2024-05-13 08:41 ./opt/ros/iron/share/zenoh_c_vendor/cmake/vendor_package_cmake_prefix.cmake
2024-05-13T08:49:10.2232801Z -rw-r--r-- root/root       432 2024-05-13 08:41 ./opt/ros/iron/share/zenoh_c_vendor/cmake/zenoh_c_vendorConfig-version.cmake
2024-05-13T08:49:10.2234666Z -rw-r--r-- root/root      1337 2024-05-13 08:41 ./opt/ros/iron/share/zenoh_c_vendor/cmake/zenoh_c_vendorConfig.cmake

Whereas rmw_zenoh_cpp searches for zenohc here: https://github.com/ros2/rmw_zenoh/blob/rolling/rmw_zenoh_cpp/CMakeLists.txt#L28C16-L28C22

So either the build of zenoh_c_vendor should somehow produce a zenohcConfig.cmake (maybe ament could do that?) or rmw_zenoh_cpp should depend on zenoh_c_vendor rather.

Timple commented 5 months ago

But your second suggestion is already the case right? https://github.com/ros2/rmw_zenoh/blob/rolling/rmw_zenoh_cpp/package.xml#L12

jspricke commented 5 months ago

That's only the build dependency, our problem is during cmake. Can you try with this line removed? https://github.com/ros2/rmw_zenoh/blob/rolling/rmw_zenoh_cpp/CMakeLists.txt#L28C16-L28C22

Timple commented 5 months ago

Then I get the same error as I get locally:

  CMake Error at CMakeLists.txt:27 (add_library):
    Target "rmw_zenoh_cpp" links to target "zenohc::lib" but the target was not
    found.  Perhaps a find_package() call is missing for an IMPORTED target, or
    an ALIAS target is missing?

Full log

jspricke commented 5 months ago

Can you push the logs to a more permanent place? Both logs seem to be expired now.

Timple commented 5 months ago

Ah, yes.

With git and network: https://github.com/nobleo/ros_debian_packages/actions/runs/9059879597/job/24888399609#step:2:5469

Without find_package(zenohc): https://github.com/nobleo/ros_debian_packages/actions/runs/9061173043/job/24892418445

jspricke commented 5 months ago

Fix is here: https://github.com/eclipse-zenoh/zenoh-c/pull/358

Timple commented 5 months ago

You're awesome! That is not something I would have cooked up in a day...

jspricke commented 5 months ago

Can you close it if there are no more issues?

Timple commented 5 months ago

Yup! Great

Timple commented 5 months ago

Thank you, all is merged and operational now. :+1: