Closed esteve closed 1 year ago
This should already be fixed in the rosotest branch, can you give it a try?
@jspricke that's great! Is there a way to continue where the build process stopped or do I have to start over?
There is currently nothing implemented but you could add a test if the resulting .deb
is already in place. Maybe we should have that as a --continue
, wanne send a PR?
@jspricke I can look into that, unfortunately our packages don't have tags and the Debian packages seem to be versioned as 0-$DATE.$TIME
(e.g. ros-humble-autoware-testing_0-2023.02.01.13.26_amd64.deb
), which would change in every run. But I'll give it a try anyway.
Correct, we need the date for ABI rebuilds. You can use a glob similar to here: https://github.com/jspricke/ros-deb-builder-action/blob/rosotest/build.sh#L81
I've pushed the improved version generation to main, any progress on the --continue
flag? Should I help?
@jspricke I won't have time to work on it, but feel free to work on it yourself if you have a spare moment
Closing as fixed with 1f3c90a and 42b0186.
When generating a package for https://github.com/tier4/tamagawa_imu_driver the
build.sh
script will use the latest tag from the repo, which is not compatible with the Debian naming conventions are thereforesbuild
aborts:The most straightforward solution would be to remove that tag from the repo or use one that follows the Debian conventions, but the
build.sh
script could also warn about and default to a safe value (like when there are no tags)