search

jspsych / experiment-demos

MIT License
2 stars 8 forks source link

finished Stroop Color Word #10

Closed steffejr closed 3 years ago

steffejr commented 3 years ago

Here is a the Stroop Color, Word and Color/Word tasks.

pjkohler commented 3 years ago

Looks great!

pjkohler commented 3 years ago

Could you make full-screen mode an optional parameter?

steffejr commented 3 years ago

OK, that you for he suggestions. I will do that. J

On Tue, Mar 9, 2021 at 3:53 PM Peter J. Kohler notifications@github.com wrote:

Could you make full-screen mode an optional parameter?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jspsych/experiment-demos/pull/10#issuecomment-794440101, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIWBI6E7NAUPNVRGJJKXYLTCZ4ENANCNFSM4Y4KUFXA .

pjkohler commented 3 years ago

apologies, @steffejr, I don't think we want to mess with override_safe_mode after all, as pointed out here: https://github.com/jspsych/experiment-demos/issues/6#issuecomment-794787828

Could you take that out again? Everything looks good, but I will try to run through the experiments tomorrow for a final check.

pjkohler commented 3 years ago

I ran through all 3 experiments and they look GREAT. I think we are about ready to merge this pull request.

I have made some minor changes so that Correct and correct are not both in the data file and practice and experiment trials are labelled differently. I think you need to make me a contributor before I can push them. @jodeleeuw is that the standard practice when a maintainer makes edit to a PR?

steffejr commented 3 years ago

Thank you Peter. I want to see how you labeled the trials differently. I could not figure that out. I do not see how to add you as a contributor to my fork.

I wonder is better for a task like this: to have one folder containing the three related versions of the task; or to have three folders?

The thing is, you really would not do one without the other two.

pjkohler commented 3 years ago

Can you not do it under settings -> manage access -> invite a collaborator?

pjkohler commented 3 years ago

I think 3 experiments are fine for now. Eventually I would want to have a single experiment, where the settings determine which subset of color block, word block and color-word block to run.

My changes are ready when you give me permission.

steffejr commented 3 years ago

I am learning everyday! I just added you. J

On Thu, Mar 11, 2021 at 12:50 PM Peter J. Kohler @.***> wrote:

Can you not do it under settings -> manage access -> invite a collaborator?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jspsych/experiment-demos/pull/10#issuecomment-796922452, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIWBI5ECFHIVVRR76HJ74DTDDYF3ANCNFSM4Y4KUFXA .

pjkohler commented 3 years ago

Okay, pushed my changes. Two more minor things:

For now I think you can just check my changes (everything should work), standardize the thank you message and then we can merge.

pjkohler commented 3 years ago

okay, I moved background color settings into a css file with the same name as the experiment folder. I think we might make that standard practice. The goal is to make adding the experiment to cognition.run as easy as possible.

can you move the viewport settings (line 9) into the css file as well, or is that not possible?

steffejr commented 3 years ago

I just tested it and it works great. I like what you did Peter for tagging the trials. I never would have thought of that.

I think it is ready to merge.