Closed Stajduhar-A closed 2 years ago
Hi @steffejr
I agree with most of your concerns, especially with regards to the cumbersome nature of the code. I have communicated these concerns to @Stajduhar-A. The plan is still that she will try to address them, but if she is unable or unwilling to find the time, I will make the necessary changes. This should be resolved with the next month or so.
Thanks!
/Peter
I mean there is a balance that needs to be struck between awesome, reusable code and a working experiment.
Also there is no setup file like we discussed to include instruction text and modifiable parameters.
I agree. For contributions to this repo I think it is fair to ask for a bit more structure to the code, rather than just a working experiment.
Hi @steffejr,
I have restructured the code to be a lot easier to read and modify.
Some limitations remain:
Let me know what you think.
/Peter
Hello Peter, I just tested this without the cars and the faces. Everything worked well as far as I could tell. There is one type-o: Line #37 of the cfmt_setup _EN.js. The word "face" is hard-coded. In the results file, I see that the response is recorded as well as the correct response. Can you go one step further and assess whether each trial is correct? I don't know how this experiment assesses the results, but can you code the stimulus that was presented, its orientation, and its noise level? Are you interested in if there are perseverative errors where the user thinks they saw one face consistently, but they did not? Just wondering. I like to get as much as possible into my results files to make my analysis step a bit easier.
Good job. IHTH, J
I will test on more time, and then merge.
Testing done. Merging.
Hello. I just ran through the experiment and tested it. Everything worked really well. Good job. I just have a couple of concerns.
It was a little 'odd' to have some photos include hair in the photos. That and the fact that once the photos started having noise added to them there were photos of different formats and cropping. It may be part of the experiment, but it through me to have a lot of images in a rather standard format and some in a different format. Maybe that is part of the experiment though!
I find the background a bit dark, making not a lot of contrast between the text and background.
I do not know what the experiment is, but based on the results file it looks like a challenge to analyze. Can you add some more info such as correct/incorrect; image upside down/rightside up; face pointed right/left/center; amount of noise added. I know you can probably extract that info from your stimulus name, but it would make your life a lot easier to incorporate it into the results during the experiment.
I am a little concerned about the "people names" included in the image file names. Is that OK?
I wonder if the code could be written in a bit more of a robust fashion. Right now it looks like A LOT of work went into this code, with each image file hard-coded and you need to specify the dimensions of every image. Why are the images not standardized in size? Or can you make a structure (stored in a JS file) that contains the image paths and their dimensions? That way you cycle through the structure and read over image path and dimensions? This is instead of hard coding it all into the main HTML file?