Questionnaires

[steffejr]

I have made a collection of questionnaires. So far this list only includes a small number of questionnaires, but the BLANK.html file can be copied and reused with many different scales once they are defined in a JS file.

[pjkohler]

@steffejr, I'll take a look at this soon. Thanks.

[pjkohler]

Hi @steffejr

Apologies for taking a while to get to this. For some reason I cannot clone your questionnaires repo, whenever I try to it just gives me the version without the Questionnaires folder. I was able to just download a zip file, however. Here are my comments:

• please delete any files and folders not used from the 'jspsych' folder
• please remove 'CSS' folder and move file "LikertQuestionnaires.css" into main folder under the name 'questionnaires.css' per the contribution guidelines.
• I found setting .jspsych-content { max-width: 90%; } rather than 100% in the css file made the questionnaires look better because they don't go all the edge of my screen
• what does var PageWidth = 800; in the general setup do at the moment? I would suggest losing the general setup file and just adding any necessary variables in each individual questionnaires setup.
• I think it is more appropriate to move individual questionnaire setups into the main folder, as they are not really assets. I know it is a lot of files in the main folder, but I still think it is better.
• I would suggest adopting let/const for variable declaration throughout. I think you are currently using a mixture of var and const.

Very impressive.

Best,

Peter

[steffejr]

Thank you Peter. I will address this feedback and try to figure out the clone problem!

On Wed, Jun 30, 2021 at 12:11 PM Peter J. Kohler @.***> wrote:

Hi @steffejr https://github.com/steffejr

Apologies for taking a while to get to this. For some reason I cannot clone your questionnaires repo, whenever I try to it just gives me the version without the Questionnaires folder. I was able to just download a zip file, however. Here are my comments:

• please delete any files and folders not used from the 'jspsych' folder
• please remove 'CSS' folder and move file "LikertQuestionnaires.css" into main folder under the name 'questionnaires.css' per the contribution guidelines.
• I found setting .jspsych-content { max-width: 90%; } rather than 100% in the css file made the questionnaires look better because they don't go all the edge of my screen
• what does var PageWidth = 800; in the general setup do at the moment? I would suggest losing the general setup file and just adding any necessary variables in each individual questionnaires setup.
• I think it is more appropriate to move individual questionnaire setups into the main folder, as they are not really assets. I know it is a lot of files in the main folder, but I still think it is better.
• I would suggest adopting let/const for variable declaration throughout. I think you are currently using a mixture of var and const.

Very impressive.

Best,

Peter

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jspsych/experiment-demos/pull/20#issuecomment-871537873, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIWBI64BNZ2IISHYIPYW7DTVM64PANCNFSM45TGGXMQ .