jspsych / jsPsych

Create behavioral experiments in a browser using JavaScript
http://www.jspsych.org
MIT License
1.02k stars 658 forks source link

Add audio selection to initialize-camera plugin #3328

Open thtTNT opened 4 weeks ago

thtTNT commented 4 weeks ago

Hi JsPhych Team,

I want to add a selectbox in initialize-camera plugin allow user to select microphone.

In most cases, recording video also means that audio is also recorded. Therefore, I think it is necessary to allow the user to choose the audio device.

I want to create a PR related to it. I would very appericate it if I can know your opinion.

jodeleeuw commented 3 weeks ago

Hi @thtTNT,

I think this is a good idea. It might make sense to consolidate the initialize-camera and initialize-microphone plugins, and just give parameters for whether developers want video, audio, or both.

thtTNT commented 3 weeks ago

Hi @jodeleeuw.

Good idea~ So I should remove the initialize-microphone plugin and modify the initialize-camera plugin? Will it affect the deployed project?

jodeleeuw commented 3 weeks ago

I think adding a new initialize-recording plugin might be the cleanest way to signal the change. Then we can deprecate the other two.