search

jspsych / jspsych-contrib

An open repository of jsPsych plugins and extensions, without any official support
44 stars 42 forks source link

Add HTML Keyboard Slider Response #118

Closed Max-Lovell closed 1 month ago

Max-Lovell commented 1 month ago

Adds a slider that accepts keypresses and a bunch of new parameters (maybe too many...). Updated Jest config to click continue button, and a few other things in there that can be commented out to check other features. A few examples are in the appropriate folder, too - all parameters listed. Let me know if clarifications needed.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: bd3aa3ef2be5fac29a24d55c49e4150c2d0f12d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------------------------------------- | ----- | | @jspsych-contrib/plugin-html-keyboard-slider | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jodeleeuw commented 1 month ago

Thanks @Max-Lovell!

Would you be willing to fill out the documentation with the parameters?

jodeleeuw commented 1 month ago

It'll also need a changeset

npm run changeset in the root directory.

Max-Lovell commented 1 month ago

Hi Josh, thanks for the quick feedback - happy to add descriptions, although I thought these were created automatically? If so, perhaps I've screwed up the markdown but can't see where - can you point me in the right direction?

jodeleeuw commented 1 month ago

Ah, we're moving in that direction, but it isn't quite done yet. You're welcome to leave as is, but it might be a couple of weeks before we have this all set up.

Max-Lovell commented 1 month ago

Hi Josh, Ah okay then - all done! Thanks

Max-Lovell commented 1 month ago

Note, implements suggestions from: https://github.com/jspsych/jsPsych/issues/2570 https://github.com/jspsych/jsPsych/pull/2827

jodeleeuw commented 1 month ago

One last thing - can you update the table in the main README for the repo to include the plugin? (hoping to automate this step in the future...)

Max-Lovell commented 1 month ago

Sure - I actually forgot to do that last time. Listed my last contrib 'survey-slider' to the main list aswell, hopefully that's alright under this PR?

Max-Lovell commented 1 month ago

Oops I screwed up the links to documentation, fixed in new PR, let me know if better way to do it here.