search

jspuij / RESTier

A turn-key library for building RESTful services
http://odata.github.io/RESTier
Other
2 stars 0 forks source link

RestierBatchChangeSetRequestItem uses ApiBase as a runtime dependency. #21

Closed jspuij closed 5 years ago

jspuij commented 5 years ago

RestierBatchChangeSetRequestItem uses ApiBase as a runtime dependency. To remove Microsoft.Extensions.DependencyInjection and make it a compile time dependency it needs to become a constructor argument.

Part of https://github.com/OData/RESTier/issues/629

jspuij commented 5 years ago

In addition. The ApiBase is disposed in this class. This is most certainly a bug, as ApiBase is supposed to be a long lived singleton.

https://github.com/OData/RESTier/blob/master/src/Microsoft.Restier.AspNet/Batch/RestierBatchChangeSetRequestItem.cs#L126-L129