jsr-io / jsr

The open-source package registry for modern JavaScript and TypeScript
https://jsr.io
MIT License
2.3k stars 104 forks source link

Looks like dry-run does not check dependency versions #438

Open krutoo opened 4 months ago

krutoo commented 4 months ago

Hi, i have workflow with series run deno publish --dry-run and deno publish: https://github.com/krutoo/utils/actions/runs/8812575981/job/24188524460

Running deno publish --dry-run passes with ok status

But deno publish fails with error:

Failed to publish @krutoo/utils at 0.0.4: specifier 'npm:@types/react' is missing a version constraint

Looks like --dry-run does not check that rule

krutoo commented 2 months ago

@lucacasonato new details: I tried to publish my package and everything was fine with dry run but without it I got an error:

Authorization successful. Authenticated as Dmitry Petrov
Publishing @krutoo/fetch-tools@0.0.16 ...
error: Failed to publish @krutoo/fetch-tools@0.0.16

Caused by:
    Failed to publish @krutoo/fetch-tools at 0.0.16: missing config file '/deno.json', is it perhaps excluded from publishing?
krutoo commented 5 days ago

any updates?

@lucacasonato