search

jsr107 / jsr107spec

JSR107 Cache Specification
Apache License 2.0
415 stars 164 forks source link

Use fine-grained getProperty for proper SecurityManager access #399

Closed aguibert closed 6 years ago

aguibert commented 6 years ago

fixes #398

vbekiaris commented 6 years ago

The PR looks good to me, so instead of requiring too broad "*" property read permission after this is merged, using JCache under a security manager will require granting permission to read "javax.cache.spi.CachingProvider" property.

@aguibert I couldn't locate you in the list of OCA-signed contributors, there are instructions on the page for signing the contributor agreement. This is required before a PR can be merged in JCache.

aguibert commented 6 years ago

@vbekiaris yikes, thanks for pointing that out, that's really down in the fine print... I saw ApacheV2 and no CONTRIBUTING.md so I figured it was standard apache license.

Signing the OCA is a no-go for me, especially for this trivial of a change. I'll have to close this PR, but hopefully it inspires someone else to fix it ;)