search

jsren / sdp-vision

http://www.youtube.com/watch?v=dQw4w9WgXcQ
1 stars 0 forks source link

Refactoring: properties don't allow specifying additional arguments #23

Open LinasKo opened 8 years ago

LinasKo commented 8 years ago

This is needed if one wants to disable median selector and/or use a smaller median. @jsren - Can we call properties by passing more arguments? I don't want the planner teams to change tiny scraps of their code again if it stops working after a change. But more than that, I don't want any unnecessary (encapsulation-improving) lines in robot_instance.

jsren commented 8 years ago

@LinasKo Two options:

  1. Control the median with another function
  2. Create a new method getX which you use only when you wish to deviate from the default.

Looks like you're going to need to refactor anyway to add the parameters. So I wouldn't change the property anyway.