search

jsreport / jsreport-core

The minimalist jsreport rendering core
GNU Lesser General Public License v3.0
86 stars 24 forks source link

update winston dependency for compatibility with Node 14 #53

Closed dlong500 closed 4 years ago

dlong500 commented 4 years ago

There is a winston 2.4.5 release that addresses some issues with Node 14. That's a very minor version bump from the current 2.4.4 that should not cause any breaking changes. Can we get a release with that upgraded dependency? I can make a PR but it might be easier on your process side to just bump that single dependency.

pofider commented 4 years ago

Thank you for the suggestion, We have the Winston update already in the backlog. This should be done very soon this year.

Closing as this is already tracked. https://github.com/jsreport/jsreport/issues/723

dlong500 commented 4 years ago

@pofider I understand that you plan to have a major winston upgrade for jsreport-core v3, but in the mean time I believe the minor update to winston v2.4.5 (from 2.4.4) would resolve the Node 14 compatibility issue.

pofider commented 4 years ago

@dlong500 Thank you for the notice, we didn't know there is such fix. The Winston is now upgraded to the 2.4.5 as suggested.

pofider commented 4 years ago

@dlong500 Unfortunately we didn't add it to the jsreport 2.10.0. So it's just in the latest jsreport-core@2.10.1 for now.