search

jsreport / jsreport-phantom-pdf

jsreport recipe which is rendering pdf from html using phantomjs
GNU Lesser General Public License v3.0
11 stars 8 forks source link

normalize waitForJS var name #1

Closed bjrmatos closed 8 years ago

bjrmatos commented 8 years ago

while developing jsreport-electron-pdf i noticed that probably is best to standardize the name of waitForJS var name across recipes to something more generic for the jsreport use case.

in jsreport-phantom-pdf and jsreport-phantom-image the var name is PHANTOM_HTML_TO_PDF_READY, while PHANTOM_HTML_TO_PDF_READY makes sense in the case of phantom-html-to-pdf but in jsreport would be more convenient to set this name equally (at least in the repositories that we maintain), so in jsreport-electron-pdf i have customized the name to JSREPORT_READY_TO_START, i think this name is more generic and does not asume that it only be used to generate PDF, in the end the waitForJS feature is generic enough to be used in any recipe (images, etc)

pofider commented 8 years ago

Ok, this makes switching between recipes easier. I guess this feature is anyway not yet used, so lets do it.

bjrmatos commented 8 years ago

:+1: i think i'm the only person taking advange of it :laughing:

pofider commented 8 years ago

It makes more sense at least for images. Thanks for good suggestion!