search

jsreport / jsreport-phantom-pdf

jsreport recipe which is rendering pdf from html using phantomjs
GNU Lesser General Public License v3.0
11 stars 8 forks source link

add support for passing an object to margin setting #17

Closed bjrmatos closed 7 years ago

bjrmatos commented 7 years ago

this should allow to apply a workaround for this problem, with this change we now have the ability to pass an object for margin setting (as documented in phantomjs website), which allows a more grained control about margin in PDF.

captura de pantalla 2017-03-27 a las 7 28 43 p m

Note: i was not able to replicate the problem on OSX or in linux (powered by docker), i only see the error on jsreport playground

pofider commented 7 years ago

Excellent. I've tested this and it works also on complex reports.

I'll only put some thoughts to the suggested format { top: "5px"..... } before I merge it.

pofider commented 7 years ago

Ok, It probably follows the best the phantomjs API. Merging it.

pofider commented 7 years ago

Thank you for this investigation and provided workaround.