search

jsreport / jsreport

javascript based business reporting platform :rocket:
https://jsreport.net
GNU Lesser General Public License v3.0
1.17k stars 225 forks source link

Consider improvements for entities git based persistence #489

Open pofider opened 5 years ago

pofider commented 5 years ago

https://forum.jsreport.net/topic/905/problems-installing-jsreport-version-control-git-on-both-windows-and-linux

pofider commented 4 years ago

From the mentioned in forum:

Could somebody update the jsreport-version-control-git module to use nodegit@0.24.0 instead of 0.23.0

This is done.

One thing I would like to see if it isn't too hard to add would be an option in the config to allow specifying a remote

This looks to be useless without push,pull, merge... We would need to invest a lot into UI here.

one other tiny nitpick on the module - the web gui is showing the ".git" repo folder as a normal folder

This was done.

one thing to note too is that it appears that the data/settings file gets changed each time you run a report - could it possibly be added to a .gitignore by default during install?

We probably get logs out of settings in the future. Let's wait for that.

https://github.com/jsreport/jsreport/issues/477 The git integration in version control got a bit broken after folders release because it takes entity set from the path. This doesn't work now and it needs to restore entity state from diff and take entity set from there. https://github.com/jsreport/jsreport-version-control-git/blob/master/lib/gitVC.js#L54 This bug should cause just minor UI problem.

This should be done one day.