search

jss2a98aj / BugTorch

Bug-fixes for Minecraft 1.7.10
MIT License
34 stars 18 forks source link

MC-1809 / leaf decay. #1

Closed Khikki closed 3 years ago

Khikki commented 3 years ago

Hello, hello. Roadhog360 recommended creating issue in BugTorch.

From the old versions, there is a bug that when generating the foliage of large trees begins to decaying.

https://youtu.be/Y5mqmsUgW-4 https://bugs.mojang.com/browse/MC-95657 https://bugs.mojang.com/browse/MC-1809 https://bugs.mojang.com/browse/MC-98557

From what I have heard, the radius that leaves can survive near a log has been increased to 6. In subsequent versions, this problem was resolved, take a look if you have any free time.

jss2a98aj commented 3 years ago

I have a fix for it in an upcoming version. I should have a beta ready in a few days, as there are some other bugs I have been attempting to fix too.

Khikki commented 3 years ago

Hey, what about beta? :)

jss2a98aj commented 3 years ago

There may be some oddities with this beta build, but go ahead and give it a try. https://www.dropbox.com/s/rf4fktiya7kedpk/BugTorch-1.0.4b2.jar?dl=1

Khikki commented 3 years ago

Hello, version 1.0.4b2 proved to be fine, however: the problem with decaying foliage has not yet been solved. 2021-03-02_18 09 55

jss2a98aj commented 3 years ago

Try with a fresh config or ensure that "fixShearedBlocksDropExtraItems" is true. The fix is currently piggybacking off of a mixin controlled by that config option. I will be separating it from that config option before the full update is done.

Khikki commented 3 years ago

Yes, I made sure that "fixShearedBlocksDropExtraItems" is true. image However, the foliage is still rotting, a screenshot from my modpacks, however, the exact same reaction was without mods. 2021-03-03_05 04 04

jss2a98aj commented 3 years ago

Odd. I'm not certain why that isn't working.

Khikki commented 3 years ago

Do you think this can be fixed? :(

jss2a98aj commented 3 years ago

Yeah. I should be able to get it working at some point.

jss2a98aj commented 3 years ago

This beta should fix the issue the last one had: https://www.dropbox.com/s/lsgsrh7lur4oul0/BugTorch-1.0.4b3.jar?dl=1

Khikki commented 3 years ago

Yes, you did a great job! Everything works as it should. It remains to solve the problem with WitchingGadgets, I am very happy thanks again!

Khikki commented 3 years ago

I would also like to ask your advice about mod trees, I don't think they are as easy to fix as vanilla trees, but I decided to ask you a question about this.

jss2a98aj commented 3 years ago

While those fixes should be implemented per mod, I may try to make fixes for some that are no longer being updated.

Khikki commented 3 years ago

What about these modifications: Biomes O' Plenty, Thaumcraft, Natura I consider them the main ones that use non-standard foliage.

jss2a98aj commented 3 years ago

I will fix Natura on its end, but the other two will likely need fixed with mixins.

jss2a98aj commented 3 years ago

The fix for this is now officially included in version 1.1.0.