jss2a98aj / BugTorch

Bug-fixes for Minecraft 1.7.10
MIT License
34 stars 18 forks source link

BugTorch 1.2.1 breaks loading progress bar mod (1.2.0 worked) #14

Closed kotmatross28729 closed 1 year ago

kotmatross28729 commented 1 year ago

There is a mod like Loading Progress Bar in bugtorch 1.2.0 release it worked, but in version 1.2.1 it no longer works

to see the Loading Progress Bar work, you need to run a VERY large modpack (in the video, a modpack containing 120 mods)

(recording lags a bit)

BugTorch 1.2.0 (work)

https://user-images.githubusercontent.com/110309314/218450024-07864491-56af-4822-a20b-74c46742467c.mp4

BugTorch 1.2.1 (does not work)

https://user-images.githubusercontent.com/110309314/218450036-ba805602-026e-4b9c-9801-868f4b435bc8.mp4

makamys commented 1 year ago

On the mod's CurseForge page, there's a comment that says the skipInitialWorldChunkLoad option is responsible for this. Do you have it enabled?

The mod is very small though (only a single class!), so we could just merge it into BugTorch or CoreTweaks with better compatibility.

kotmatross28729 commented 1 year ago

Oh yeah, disabling skipInitialWorldChunkLoad helps, thanks a lot! (and yes, I would like it to be merged into one of these mods, that would be very cool)

jss2a98aj commented 1 year ago

BugTorch 1.2.0 was failing to apply mixins for some people. Sometimes failing to apply mixins was fixed in 1.2.1. I think the loading bar was working with 1.2.0 because the conflicting mixin was not applied.

Adding a similar feature in as makamys suggested is probably how I will fix the problem.