search

jss2a98aj / NotFine

Extra video settings for Minecraft 1.7.10 implemented with Mixins
Other
35 stars 11 forks source link

Incompatibility with CustomThings #40

Open song682 opened 4 months ago

song682 commented 4 months ago

While isOpaque was enabled (The function of isOpaque can be seen at here), Notfine 0.2.5 will crash with CustomThings. here is my CustomThings' config of customBlock.json

{"data":
    [
        {
        "name": "copper_grate",
        "type": "metal",
        "shape": "normal",
        "hardness": 1.0,
        "resistance": 8.0,
        "harvestLevel": 2,
        "toolType": "pickaxe",
        "isOpaque": false,
        "maxStackSize": 64
        },
        {
        "name": "polished_tuff",
        "type": "rock",
        "shape": "normal",
        "hardness": 1.0,
        "resistance": 6.0,
        "harvestLevel": 1,
        "toolType": "pickaxe",
        "isOpaque": true,
        "maxStackSize": 64
        },
        {
        "name": "tuff_bricks",
        "type": "rock",
        "shape": "normal",
        "hardness": 1.0,
        "resistance": 6.0,
        "harvestLevel": 2,
        "toolType": "pickaxe",
        "isOpaque": true,
        "maxStackSize": 64
        }
    ]
}
Roadhog360 commented 4 months ago

Tangentially related: All of those blocks are coming in EFR 2.6.1

song682 commented 4 months ago

Tangentially related: All of those blocks are coming in EFR 2.6.1

OKOK

song682 commented 4 months ago

Tangentially related: All of those blocks are coming in EFR 2.6.1

Go off on a tangent, I wanna a explain about why I can't use matchBlocks in CTM in order to connect colorless glass?
I even use the same flie in the ctm folder. [1.7.10]ConnectingGlassReCom[v1.4.3].zip This is the texture pack.

jss2a98aj commented 4 months ago

Tangentially related: All of those blocks are coming in EFR 2.6.1

Go off on a tangent, I wanna a explain about why I can't use matchBlocks in CTM in order to connect colorless glass? I even use the same flie in the ctm folder. [1.7.10]ConnectingGlassReCom[v1.4.3].zip This is the texture pack.

Thta is likely a bug in the MCPatcher CTM port.

jss2a98aj commented 4 months ago

While isOpaque was enabled (The function of isOpaque can be seen at here), Notfine 0.2.5 will crash with CustomThings. here is my CustomThings' config of customBlock.json

{"data":
  [
      {
      "name": "copper_grate",
      "type": "metal",
        "shape": "normal",
        "hardness": 1.0,
      "resistance": 8.0,
        "harvestLevel": 2,
      "toolType": "pickaxe",
        "isOpaque": false,
        "maxStackSize": 64
        },
      {
      "name": "polished_tuff",
      "type": "rock",
        "shape": "normal",
        "hardness": 1.0,
      "resistance": 6.0,
        "harvestLevel": 1,
      "toolType": "pickaxe",
        "isOpaque": true,
        "maxStackSize": 64
        },
      {
      "name": "tuff_bricks",
      "type": "rock",
        "shape": "normal",
        "hardness": 1.0,
      "resistance": 6.0,
        "harvestLevel": 2,
      "toolType": "pickaxe",
        "isOpaque": true,
        "maxStackSize": 64
        }
  ]
}

Can you post a crash log please?

Roadhog360 commented 4 months ago

@KibaTheBarbarian I think you also know of a one or two other mods that allow you to add custom blocks using a config. Maybe they will work?

song682 commented 4 months ago

While isOpaque was enabled (The function of isOpaque can be seen at here), Notfine 0.2.5 will crash with CustomThings. here is my CustomThings' config of customBlock.json

{"data":
    [
        {
        "name": "copper_grate",
        "type": "metal",
        "shape": "normal",
        "hardness": 1.0,
        "resistance": 8.0,
        "harvestLevel": 2,
        "toolType": "pickaxe",
        "isOpaque": false,
        "maxStackSize": 64
        },
        {
        "name": "polished_tuff",
        "type": "rock",
        "shape": "normal",
        "hardness": 1.0,
        "resistance": 6.0,
        "harvestLevel": 1,
        "toolType": "pickaxe",
        "isOpaque": true,
        "maxStackSize": 64
        },
        {
        "name": "tuff_bricks",
        "type": "rock",
        "shape": "normal",
        "hardness": 1.0,
        "resistance": 6.0,
        "harvestLevel": 2,
        "toolType": "pickaxe",
        "isOpaque": true,
        "maxStackSize": 64
        }
    ]
}

Can you post a crash log please?

here : crash-2024-08-05_13.31.00-client.txt
And I also comment another issues about wrong connections. https://github.com/jss2a98aj/NotFine/issues/38#issuecomment-2241199368

Roadhog360 commented 4 months ago

For future reference, it is a better idea to use Gist or a paste website. It's annoying to have to download your crash report just to view it.

song682 commented 4 months ago

For future reference, it is a better idea to use Gist or a paste website. It's annoying to have to download your crash report just to view it.

Oh, okay, Sorry. @Roadhog360

Roadhog360 commented 4 months ago

Np I'll download it this time but wanted to let you know :)

song682 commented 3 months ago

And a collapse with Xaero's MiniMap & WorldMap.
crash-2024-08-07_00.00.04-client A lot of weird render problem when I'm scrolling the Decoration Block tab, caused when I scroll down, after the Work Bench, Furnace, & Chest. A lot of blocks disappear. And then those blocks on the top of them has been rendering weirdly.This is the picture. And I even can't get a block.(Maybe I need to mention it to Xaero.)
2024-08-07_00 13 04

Roadhog360 commented 3 months ago

If this is for a different mod, please open separate issues

song682 commented 3 months ago

If this is for a different mod, please open separate issues

Ok, I'll.

jss2a98aj commented 3 months ago

And a collapse with Xaero's MiniMap & WorldMap. crash-2024-08-07_00.00.04-client A lot of weird render problem when I'm scrolling the Decoration Block tab, caused when I scroll down, after the Work Bench, Furnace, & Chest. A lot of blocks disappear. And then those blocks on the top of them has been rendering weirdly.This is the picture. And I even can't get a block.(Maybe I need to mention it to Xaero.) 2024-08-07_00 13 04

This particular issue should already be fixed in dev. I need to release an update soon.

song682 commented 3 months ago

And a collapse with Xaero's MiniMap & WorldMap. crash-2024-08-07_00.00.04-client A lot of weird render problem when I'm scrolling the Decoration Block tab, caused when I scroll down, after the Work Bench, Furnace, & Chest. A lot of blocks disappear. And then those blocks on the top of them has been rendering weirdly.This is the picture. And I even can't get a block.(Maybe I need to mention it to Xaero.) 2024-08-07_00 13 04

This particular issue should already be fixed in dev. I need to release an update soon.

OK