search

jssimporter / JSSImporter

JSSImporter is deprecated. Please see the wiki for alternatives
Apache License 2.0
145 stars 38 forks source link

Use zipfile instead of shutil to handle large pkgs >2GB #126

Closed grahampugh closed 6 years ago

grahampugh commented 6 years ago

I switched from using shutil to using zipfile which allows the allowZip64=True setting to enable folders larger than 2GB or 65536 files to be zipped.

I tested it on Adobe Illustrator and it behaved as it should

sheagcraig commented 6 years ago

@grahampugh maybe I'm just bad at git, but the first commit above looks like it's copying the 1.0.0 file plus your changes on top of the 0.5.1 code; perhaps copy the one commit with the zipfile changes to the tip of a clean branch based off of testing?

I think I know how to do this if you want me to try to explain it; or you could just cut and paste!

I'll get this merged into testing as soon as possible, along with @mosen's change that's already in and reissue another beta installer.