Closed krypted closed 3 years ago
Hello sir, I pulled this down and made some changes; most of which were style.
The big ones were removing the hardcoded Google Chrome data and rewriting stuff to use curl since we can't easily add requests (back) as a dependency to this project.
A few questions I had:
I think you should be able to rebase off of my krypted-master branch to get this one up to date with my changes.
Hello @sheagcraig ,
I am working with Charles on implementing these changes and testing on my servers. Do you anticipate the Patch Server URL to be hardcoded where you would normally put in your Jamf API creds? Or somewhere in the script? And too, Bundle ID is not an imminent need, just a nice to have on the Patch Server.
Let me know your thoughts, thanks!
Hi @yuresko, So my expectation would be that the Patch Server URL would be stored in the same preferences file that JSSImporter uses for all of its other settings..
@yuresko Would it be realistic to think that each patch recipe might point to a different patch server? For instance, many recipes might point to Bryson’s community patch server, but one might need an internal or separate patch server for in-house apps. If so, we will need to specify the URL in the recipe itself.
Also, can this process work without the preamble associated with patch? For example, does it ensure that the patch user agreement has been agreed via the UAPI? Does it create a fresh patch definition object (forgive me if I’m getting the terminology wrong) or does it already need to exist? It would be nice if it worked “out of the box”.
I suspect this is dead but will leave it here in case and of the authors wish to pursue it,
Fair to say that this is dead.
Corrected typo in line 696 and added link to Bryson's PatchServer in comments when we kick off the patch server post to json