search

jssimporter / JSSImporter

JSSImporter is deprecated. Please see the wiki for alternatives
Apache License 2.0
145 stars 38 forks source link

[1.0.2b3] global name 'urllib' is not defined #151

Closed dakh7 closed 5 years ago

dakh7 commented 5 years ago

Hi, I'm getting an error now when running jss recipes with version 1.0.2b3, global name 'urllib' is not defined. Was working fine previously with 1.0.2b2. 


WARNING: firefox.jss is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding...
MozillaURLProvider
MozillaURLProvider: Found URL https://download.mozilla.org/?product=firefox-latest&os=osx&lang=en-US
URLDownloader
URLDownloader: Item at URL is unchanged.
URLDownloader: Using existing /Users/username/Library/AutoPkg/Cache/com.github.jss-recipes.jss.Firefox_EN/downloads/Firefox.dmg
EndOfCheckPhase
CodeSignatureVerifier
CodeSignatureVerifier: Mounted disk image /Users/username/Library/AutoPkg/Cache/com.github.jss-recipes.jss.Firefox_EN/downloads/Firefox.dmg
CodeSignatureVerifier: Using path '/private/tmp/dmg.COEhqV/Firefox.app' matched from globbed '/private/tmp/dmg.COEhqV/Firefox*.app'.
CodeSignatureVerifier: Verifying code signature...
CodeSignatureVerifier: Deep verification enabled...
CodeSignatureVerifier: Strict verification not defined. Using codesign defaults...
CodeSignatureVerifier: /private/tmp/dmg.COEhqV/Firefox.app: valid on disk
CodeSignatureVerifier: /private/tmp/dmg.COEhqV/Firefox.app: satisfies its Designated Requirement
CodeSignatureVerifier: /private/tmp/dmg.COEhqV/Firefox.app: explicit requirement satisfied
CodeSignatureVerifier: Signature is valid
AppDmgVersioner
AppDmgVersioner: Mounted disk image /Users/username/Library/AutoPkg/Cache/com.github.jss-recipes.jss.Firefox_EN/downloads/Firefox.dmg
AppDmgVersioner: BundleID: org.mozilla.firefox
AppDmgVersioner: Version: 67.0.3
PkgRootCreator
PkgRootCreator: Created /Users/username/Library/AutoPkg/Cache/com.github.jss-recipes.jss.Firefox_EN/Firefox
PkgRootCreator: Created /Users/username/Library/AutoPkg/Cache/com.github.jss-recipes.jss.Firefox_EN/Firefox/Applications
Copier
Copier: Mounted disk image /Users/username/Library/AutoPkg/Cache/com.github.jss-recipes.jss.Firefox_EN/downloads/Firefox.dmg
Copier: Copied /private/tmp/dmg.dWWasu/Firefox.app to /Users/username/Library/AutoPkg/Cache/com.github.jss-recipes.jss.Firefox_EN/Firefox/Applications/Firefox.app
PkgCreator
PkgCreator: Package already exists at path /Users/username/Library/AutoPkg/Cache/com.github.jss-recipes.jss.Firefox_EN/Firefox-67.0.3.pkg.
PkgCreator: Existing package matches version and identifier, not building.
JSSImporter
JSSImporter: python-jss version: 2.0.1.
JSSImporter: JSSImporter version: 1.0.2b3.
global name 'urllib' is not defined
Failed.
Receipt written to /Users/username/Library/AutoPkg/Cache/com.github.jss-recipes.jss.Firefox_EN/receipts/firefox-receipt-20190619-113118.plist

The following recipes failed:
    firefox.jss
        Error in com.github.jss-recipes.jss.Firefox_EN: Processor: JSSImporter: Error: global name 'urllib' is not defined

Nothing downloaded, packaged or imported.```
grahampugh commented 5 years ago

Hi @dakh7 this is addressed with https://github.com/jssimporter/python-jss/pull/92 - just waiting approval from @mosen in case I missed something.

grahampugh commented 5 years ago

This should now be fixed.