search

jssimporter / JSSImporter

JSSImporter is deprecated. Please see the wiki for alternatives
Apache License 2.0
145 stars 38 forks source link

Element has no attrobute #196

Open itsupportzf opened 2 years ago

itsupportzf commented 2 years ago

JSSImporter: Copied '/Users/mluffy/Library/AutoPkg/Cache/com.github.novaksam.jss.Evernote/Evernote-10.40.9.pkg' 'Element' object has no attribute 'getchildren' Failed. Receipt written to /Users/mluffy/Library/AutoPkg/Cache/com.github.novaksam.jss.Evernote/receipts/Evernote.jss-receipt-20220718-172643.plist

The following recipes failed: Evernote.jss.recipe Error in com.github.novaksam.jss.Evernote: Processor: JSSImporter: Error: 'Element' object has no attribute 'getchildren'

Above is the error i get whenever i try to push a new .pkg. i am on the latest jssimporter. please advice. OS12.4

user1233445 commented 2 years ago

I receive the same error message

stewiem2000 commented 2 years ago

In case anyone else wants to fix this before transitioning over to e.g. JamfUploader, the getchildren() call is deprecated and /Library/AutoPkg/JSSImporter/jss/jssobject.py needs all (four) instances of foo.getchildren() updating to list(foo).

grahampugh commented 2 years ago

@stewiem2000 if you submit a PR with the changes you have made to make it work, I will try and create a new release.

stewiem2000 commented 2 years ago

I think I've done now done that @grahampugh — appologies if I've messed it up :)

stewiem2000 commented 2 years ago

Hah! And now I find the exact same changes (and more) in another pull request 🤦‍♂️

novaksam commented 2 years ago

I think I encountered some issues in the XML response parsing that break things further down the line, but I've reverted to 2.6 (or earlier, I don't remember) as I'm going to convert my stuff to jamf uploader policies.