search

jssimporter / jss_helper

jss_helper is deprecated.
GNU General Public License v3.0
66 stars 7 forks source link

FEU not sticking #16

Open mikevmeyer opened 8 years ago

mikevmeyer commented 8 years ago

Love jss_helper... such a great tool!

I've noticed that when I promote a package, it strips any FEU settings I may have set in Casper Admin. Workflow is as follows: upload package to JSS via Casper Admin, set category, FEU options, etc. in Casper Admin, then call up jss_helper and promote the package to the appropriate policy. Bit of a JSS newb here, and I've got a slick install of AutoPkgr running with a few JSS recipes, so maybe there's a workflow step I'm missing here? Or maybe it's more of a jss_helper thing?

Thoughts?

sheagcraig commented 8 years ago

Hey @mikevmeyer nice to hear from you.

I'm guessing it definitely is not something you're doing wrong. Just looking at the code to review, however, it just takes the name/id of the new package and replaces the name/id of the old package in the policy object. The policy doesn't handle any of that information (it's delegated to the package object); so jss_helper doesn't modify the package at all.

Are you sure that subsequent AutoPkg runs aren't modifying the package object after you have set the FEU, etc?

Also something to check-in the way you describe your process above, are you saving the changes you made to the package before you run jss_helper? Its been awhile, but if I remember correctly, you have to manually hit SAVE in Casper Admin to commit changes (and potentially sync them too?), or quit Casper Admin, before the API will have access to the updated values.

mikevmeyer commented 8 years ago

Hi @sheagcraig, thanks for the reply... I'm definitely going to take a hard look at the workflow, before any real red flags should be raised on this issue.

You mention really good points about making sure the SAVE in Casper Admin and commit/sync processes have fully finished before running jss_helper. I do recall moving fairly quickly thru these workflows, and it's very well possible the JSS just hadn't caught up to the time I went in and did the jss_helper actions. I'm going to test those very carefully, and I'll let you know the results....

BTW, I've been using all of these tools with a hosted instance of the JSS, and they do work quite well!