Closed mosen closed 6 years ago
Added another commit which resolves request headers not being properly supplied to curl eg. OBJECT_ID
instead of OBJECT_ID: 1
due to a statement being array += dict
.
OMG. I've been in holiday ignoring-Github land. Seems as if you've been busy. Can you give me a summary of what all is going on here, and where you are? Thanks!
Sorry this went a bit insane, and I didn't end up making feature branches for every added feature. The summary:
Thats about it!
Worth mentioning that the NSURLSessionAdapter would break uploads in its current state so hold off :)
I'm down for everything that's going on here. It's such a huge change that I'm wondering how to merge it though.
Also, about the tests: They are definitely tied to a JSS I used to have, so they won't even run now. My understanding is that they should still run under pytest (and that's what I would use if I get around to updating them). They just need to be updated to mock out the responses that I have hardcoded in (and had an actual server to respond to).
This is 342 commits ahead of your fork haha. No chance of merging anything. I need to examine how I can divide the spaghetti using surgical precision git cherry-pick or maybe a file by file basis
ok im assessing how to split this.
probably:
Rather than cherry pick the commits i feel like starting new ones on a new branch in case there are commits that run across those functions.
Split into multiple PRs
subprocess seems to bail when it encounters a list that contains a File object, example print debug:
This may or may not be the issue affecting CDP.