search

jssimporter / python-jss

python-jss is deprecated. Please see the wiki for alternatives.
GNU General Public License v3.0
102 stars 41 forks source link

Python3 compatibility #93

Closed sailedeer closed 4 years ago

sailedeer commented 4 years ago

I'm wondering if Python3 compatibility is planned for python-jss. I've been using 2to3 to try and get it running for the sake of testing, but that's not feasible for installation on other machines.

grahampugh commented 4 years ago

Edit original comment (I thought this was an issue raised about JSSImporter): the work has begun but is not complete.

mosen commented 4 years ago

The biggest issue was that sheagcraig had subclassed etree.ElementTree for the XML objects which worked in 2 but is a really difficult strategy to carry forward into py 3 because etree breaks when subclassed. Basically the approach was proxying method calls to an underlying etree instance

grahampugh commented 4 years ago

@sailedeer please test out the 2.1.0-dev branch.

sailedeer commented 4 years ago

Will try and take a look some time this week. Thanks for the update.

grahampugh commented 4 years ago

Python3 compatibility is now merged into master.