Add an error dialog to Launcher when selecting an invalid mountpoint - Githubissues

jstaf / onedriver

A native Linux filesystem for Microsoft OneDrive

GNU General Public License v3.0

1.88k stars 92 forks source link

Add an error dialog to Launcher when selecting an invalid mountpoint #280

Closed erik88 closed 1 year ago

erik88 commented 1 year ago

First of all, thank you for a superb application!

Case/Reason for change

When launching Onedriver Launcher from desktop (non CLI), it will silently fail when trying to select a non-empty directory.

If the directory contains hidden files (like backup files from vim/drawio), this gets very confusing.

Changes

Added an error dialog to Onedriver Launcher when trying to add an invalid mountpoint.

Finally

Please let me know something should be changed, if the PR is malformed, or if for some reason it should be rejected :)

jstaf commented 1 year ago

Looks great and works as described! Thanks for the contribution :slightly_smiling_face: