search

jstaf / onedriver

A native Linux filesystem for Microsoft OneDrive
GNU General Public License v3.0
1.95k stars 96 forks source link

Rename the onedriver desktop entry to fix the window icon in the GNOME workspace switcher #369

Closed foopsss closed 10 months ago

foopsss commented 10 months ago

At least in the Wayland GNOME session for an app icon to appear under its respective window in the workspace switcher, instead of a placeholder icon with gears, the .desktop file has to have the same name (application identifier) as the process it's going to execute.

I have confirmed on my device that renaming the "onedriver.desktop" file to "onedriver-launcher.desktop" fixes the issue and the onedriver icon is displayed under the window of the GUI instead of the placeholder in the workspace switcher.

I went ahead and made this PR after changing all the instances I could find in the repo where the wrong name for the .desktop file was being used, but I'd feel more comfortable if you could also take a look at this as well and tell me what you think.

jstaf commented 10 months ago

omfg was that the actual issue all this time?!!? Wow, good fix. Thank you :smile_cat:

foopsss commented 10 months ago

Yeah, it's very silly, I've just learnt it last week in the GNOME subreddit. I've patched the Gentoo ebuilds a few days ago to fix this issue so the icons will display correctly for both 0.13.0 and 0.14.1 now.