search

jstedfast / gmime

A C/C++ MIME creation and parser library with support for S/MIME, PGP, and Unix mbox spools.
GNU Lesser General Public License v2.1
113 stars 36 forks source link

autogen.sh has invalid shell syntax #109

Closed dkg closed 2 years ago

dkg commented 2 years ago

in bfa72b11943204a0955bb3a0a603f7c56ca97f1e autogen.sh adopted $(srcdir) instead of $srcdir -- but this isn't valid equivalent syntax in shell. Maybe you meant ${srcdir} instead? $(xxx) executes a subshell running the program xxx and substitutes its output, while ${xxx} expands an environment variable named xxx.

dkg commented 2 years ago

(the switch in that same commit from which to command -v is distinct from this variable substitution syntax mixup, and is probably ok, and worth keeping)

jstedfast commented 2 years ago

Thanks, this should be fixed now I think