jstedfast
commented
2 years ago Fixed
Closed kloczek closed 2 years ago
jstedfast
commented
2 years ago Fixed
kloczek
commented
2 years ago Issue still is not fixed because there is no dependency checking for gpg-error in configure.ac
kloczek
commented
2 years ago Here is the patch which I'm using now which as well modernises use pkg-config
--- a/configure.ac~ 2022-06-04 12:57:15.000000000 +0000
+++ b/configure.ac 2022-06-04 14:24:15.731329956 +0000
@@ -283,21 +283,11 @@
esac
dnl
-dnl zlib support
+dnl checking pkg-config dependencies
dnl
-PKG_CHECK_MODULES([ZLIB], [zlib], [found_zlib=yes], [found_zlib=no])
-AS_IF([test "x$found_zlib" = "xno"], [
- AC_CHECK_LIB(z, inflate, [AC_CHECK_HEADER(zlib.h, found_zlib=yes)])
- if test "x$found_zlib" = "xno" ; then
- AC_MSG_ERROR([*** Working zlib library and headers not found ***])
- fi
- ZLIB_LIBS='-lz'
-])
-
-dnl We need at *least* glib 2.16.0 for GIO, 2.18.0 for g_set_error_literal, 2.32.0 for g_mutex_init, and 2.58 for g_time_zone_new_offset
-AM_PATH_GLIB_2_0(2.58.0, ,
- AC_MSG_ERROR(Cannot find GLIB: Is pkg-config in your path?),
- gobject gmodule gthread gio)
+PKG_CHECK_MODULES([ZLIB], [zlib])
+PKG_CHECK_MODULES([GPG_ERRPR], [gpg-error])
+PKG_CHECK_MODULES([GLIB], [glib-2.0 >= 2.58.0 gio-2.0])
CFLAGS_save="$CFLAGS"
CFLAGS="$CFLAGS -I$srcdir"
@@ -486,7 +476,7 @@
AC_ARG_WITH(libidn, AS_HELP_STRING([--with-libidn=[DIR]],[Support IDN (needs GNU Libidn)]),
libidn=$withval, libidn=yes)
if test "$libidn" != "no" ; then
- PKG_CHECK_MODULES(LIBIDN, libidn2 >= 2.0.0, [libidn=yes], [libidn=no])
+ PKG_CHECK_MODULES([LIBIDN], [libidn2 >= 2.0.0], [libidn=yes], [libidn=no])
if test "$libidn" != "yes" ; then
libidn=no
AC_MSG_WARN([Libidn not found])
--- a/tests/Makefile.am~ 2022-06-04 12:57:15.000000000 +0000
+++ b/tests/Makefile.am 2022-06-04 14:28:50.781442552 +0000
@@ -42,7 +42,8 @@
noinst_PROGRAMS = $(AUTOMATED_TESTS) $(MANUAL_TESTS)
DEPS = $(top_builddir)/gmime/libgmime-$(GMIME_API_VERSION).la
-LDADDS = $(top_builddir)/gmime/libgmime-$(GMIME_API_VERSION).la $(GLIB_LIBS)
+LDADDS = $(top_builddir)/gmime/libgmime-$(GMIME_API_VERSION).la $(GLIB_LIBS) $(GPG_ERROR_LIBS)
+AM_CFLAGS = $(GPG_ERROR_CFLAGS)
test_best_SOURCES = test-best.c
test_best_LDFLAGS =
--- a/tests/test-pkcs7.c
+++ b/tests/test-pkcs7.c
@@ -32,6 +32,7 @@
#include <gmime/gmime.h>
#include <gmime/gmime-pkcs7-context.h>
+#include <gpg-error.h>
#include <gpg-error.h>
Please let me know if you want that as PR.
jstedfast
commented
2 years ago Your patch didn't work for me, but I committed a fixed up version
kloczek
commented
2 years ago OK I see your point. I've tested in my packaging procedure all up to 5cde40c7 and it is better solution than mine. Thank you 👍
Looks like latest version depends on gpg-error:
Because of that build fails: