jstedfast / gmime

A C/C++ MIME creation and parser library with support for S/MIME, PGP, and Unix mbox spools.
GNU Lesser General Public License v2.1
114 stars 36 forks source link

Add helper for reading the GMimeFilterChecksum result as string #34

Closed albrechtd closed 6 years ago

albrechtd commented 6 years ago

Add an alternative method for retrieving the result of a GMimeFilterChecksum: the new method acts as a wrapper for calling g_checksum_get_string() on the underlying GChecksum, but makes a copy of the value so it is not destroyed when the filter is unref'ed.

Reason: I always need the hex string, and could save a few lines of code…

jstedfast commented 6 years ago

In the future, it might be saner to create a fresh branch for each PR so that it's not cluttered with a bunch of Merge remote-tracking branch 'upstream/master' noise.

albrechtd commented 6 years ago

Ok, sorry… I'm not a Git expert, unfortunately – is it possible to "rebase" the fork to upstream? I.e. to skip all the intermediate steps?

jstedfast commented 6 years ago

You could try git rebase -i upstream and then do a git push --force on your end after rebasing