search

jstedfast / gmime

A C/C++ MIME creation and parser library with support for S/MIME, PGP, and Unix mbox spools.
GNU Lesser General Public License v2.1
113 stars 36 forks source link

Expose signature creation time and expiration time as guint64 #69

Closed dkg closed 4 years ago

dkg commented 4 years ago

This is a very conservative change that attempts to address #68.

It avoids changing the memory layout of the GMimeSignature object, since it might accessed directly by a user who doesn't use the function interface.

It takes a different approach to indicating a failure than the established (time_t)-1 mechanism, to encourage safer use.

Signed-off-by: Daniel Kahn Gillmor dkg@fifthhorseman.net

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.09%) to 64.548% when pulling 338ab7164d2f5ad7696db7618c0bb8d92068d128 on dkg:sigtime into c46ee83921d88e9d52bbf11df13835604472b970 on jstedfast:master.

dkg commented 4 years ago

thanks for e797efeb476b9773b79b8ab36a70f070adfcc976, which i think addresses the underlying issue, albeit in a different way than i've dealt with it here. For GMime 4.0, we can think about other ways to fix the problem, like #73.