Explain units for g_mime_{certificate,signature}_get_{created,expires}64

jstedfast / gmime

A C/C++ MIME creation and parser library with support for S/MIME, PGP, and Unix mbox spools.

GNU Lesser General Public License v2.1

113 stars 36 forks source link

Explain units for g_mime_{certificate,signature}_get_{created,expires}64 #72

Closed dkg closed 4 years ago

dkg commented 4 years ago

The standard gmime{certificate,signature}get{created,expires} functions return a time_t whose units are well-defined by the operating system.

The new 64-bit accessors provide a gint64, which has no such implicit definition, so GMime should be explicit about what it intends these values to represent.

Signed-off-by: Daniel Kahn Gillmor dkg@fifthhorseman.net

coveralls commented 4 years ago

Coverage decreased (-0.08%) to 64.466% when pulling 416726e31876e088922c127a4bb094511dd91e5c on dkg:time64 into e797efeb476b9773b79b8ab36a70f070adfcc976 on jstedfast:master.