search

jstejada / react-typist

Typing animations with React
https://jstejada.github.io/react-typist/
Other
1.4k stars 124 forks source link

Not working properly with react-intl #19

Open Pomanks opened 7 years ago

Pomanks commented 7 years ago

I've encountered some issues working with react-typist :

• It doesn't work if you use react-intl with <FormattedMessage/> tags (the text isn't written). • It works fine if you use instead {formatMessage()} inside the <span> tag but.. as soon as the text is written, you'd have to reload the page to translate it either way it won't (and you have then some text in one language and what's left in a second one..). Not that pretty :/

Anyway to correct this ? I'm not saying I use it perfectly cause I'm quite new to react and react-intl but I'm posting this just so you're aware of these issues (and in case someone has a solution) 👍

Anyway, your solution if pretty neat and useful.

jstejada commented 7 years ago

Thanks for the heads up! I'll take a look at how we can improve this

jstejada commented 6 years ago

might be related to #29

smakosh commented 6 years ago

Having the same issue as @Pomanks

ohlr commented 4 years ago

I am using i18next and used the workarround described in #29 i.e.:

<Typist key={t("some translation")}>
...
</ Typist>