search

jstejada / react-typist

Typing animations with React
https://jstejada.github.io/react-typist/
Other
1.4k stars 124 forks source link

should avoid using global class names for blinking cursor #77

Open p0o opened 5 years ago

p0o commented 5 years ago

At the moment the blink cursor is using this global css name .Typist .Cursor--blinking.

Importing this stylesheet with modern tooling like CSS Modules results to a transformed name which is not a match to the classname above.

Also not a very good practice, a better approach could be implementing it using styled-components or injecting the stylesheet inside header within the component scope.

Any thoughts?