search

jstemmer / go-junit-report

Convert Go test output to JUnit XML
MIT License
764 stars 222 forks source link

Summary of the test is not considered for Fail/Pass status of the test #87

Closed utka closed 4 years ago

utka commented 5 years ago

Looking into the code: https://github.com/jstemmer/go-junit-report/blob/af01ea7f8024089b458d804d5cdf190f962a9a0c/parser/parser.go#L230 Looks like if summary is FAIL, the test still going to be marked as Pass.

Example: === RUN TestApplyThrice 2019-05-02T02:00:14.273826Z info Graceful termination period is -10s, starting... --- PASS: TestApplyThrice (0.00s) 2019-05-02T02:00:14.274025Z info Epoch 0 starting panic: Fail in goroutine after TestApplyThrice has completed FAIL istio.io/istio/pilot/pkg/proxy 0.008s