search

jstemmer / go-junit-report

Convert Go test output to JUnit XML
MIT License
776 stars 224 forks source link

Adjust xml annotations to allow unmarshal of test suites #93

Closed johnSchnake closed 5 years ago

johnSchnake commented 5 years ago

The xml annotations currently used allow for marshalling of the test suites but fail to unmarshal them because of the lack of an xml annotation on the slice fields for test suites and test cases.

By adding those annotations, these types can be more widely reused.

Fixes #92

johnSchnake commented 5 years ago

@jstemmer I'm hopeful you'll consider this adjustment. As the PR comment mentions it should make the types more widely useable. In my case I was hoping to use them in Sonobuoy for the time being since the multi-suite nature seems to be a generalization of the types specified in onsi/ginkgo

johnSchnake commented 5 years ago

Test updated to not utilize subtests due to your CI testing on older versions of Go without that feature.

jstemmer commented 5 years ago

Looks good and +1 for adding the formatter test. Thank you!