search

jstnhuang / ros-websocket

A Polymer element wrapping roslibjs's ROS object.
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Polymer 1 support #2

Open mvollrath opened 5 years ago

mvollrath commented 5 years ago

I'm working on a Polymer 1 project that uses ros-websocket. We need to use the newest (not yet released) version of roslibjs which adds CBOR binary encoding support.

For development, I've forked this repo at v3.0.2 with the new roslib version. We'd like to use a tagged release instead.

Since roslib doesn't have a major version yet, it seems like there would need to be a branch for 3.x and release every time roslib releases to keep it up to date and prevent breaking changes.

I'm appealing to roslibjs for a major version release so we can reduce the maintenance overhead of 3.x.

chapulina commented 5 years ago

@jstnhuang, let us know if you're interested in keeping a branch that supports Polymer 1. Otherwise, we will fork this under the osrf org and use that for RVizWeb instead (at least while we're still using Polymer 1). Thanks!

jstnhuang commented 5 years ago

Hi @mvollrath and @chapulina,

Thanks for keeping me updated about these issues. I'll just say that I made the 4.0 version of ros-websocket mostly as an experiment to see how hard it would be to move things to Polymer 3. I'd be happy to have one branch for Polymer 1/2 and another for Polymer 3. I think that if I were in your position, I would just want to fork this repo. That would give you the most control over the code, so you can make changes whenever you want.

That being said, I appreciate being updated on the changes you're working on. I'll definitely try updating roslib to v1.0.0 and creating a new branch sometime.

chapulina commented 5 years ago

Thanks for the feedback!

@mvollrath , I created forks https://github.com/osrf/polymer-ros-websocket and https://github.com/osrf/polymer-ros-service, feel free to make PRs to those repos and change other components to use them for now. Thanks!