search

jstnjns / min-ui

A minimal UI for Atom
3 stars 2 forks source link

Theme makes pop-up menus unreadable #1

Closed mattringel closed 7 years ago

mattringel commented 8 years ago

Using Atom on Windows 10. This theme makes pop-up menus such as the command pallette and the new folder form unreadable with a red background. I tried it with various syntax themes and they all have the same problem.

image

MutableLoss commented 8 years ago

Yes, same issue with Linux Ubuntu 15.04, and OSX El Capitan.

First off, I want to say this theme is great!

It seems that the only issue is in the inactive dropdown fonts. A unsaturated gray on top of a highly saturated red blends right in:

command

You can see this same behavior when using a dropdown menu where the bg is white, but the font is still that same light gray:.

font

I'm not an Atom theme creator, so I have no idea if this font is somewhere else. A low value colored font should fix these areas, but I'm guessing they could be used somewhere else where it would break things (Command palette hotkey background?).

Thanks, and hope to see an update soon! So nice to have a dark minimal theme. :)

ghost commented 7 years ago

same on mac, @sdomula's PR fixes it

min-ui-fixed-overlay