search

jstockwin / Film-Night

0 stars 0 forks source link

Searching shouldn't return another instance of films already selected #28

Closed unpairedbracket closed 8 years ago

unpairedbracket commented 8 years ago

selection_096

Tom-Johnston commented 8 years ago

Why not?

unpairedbracket commented 8 years ago

Because people might abuse it for films that aren't The Guard?

Tom-Johnston commented 8 years ago

They could just reload the page and add it again. Only allowing people to vote once should be handled server side. They could even send POST requests straight to the back end.

jstockwin commented 8 years ago

In theory this could be an issue, as people could give a certain film a really high frequency, making it very likely to come up.

However, we currently completely ignore frequency, so doing this won't actually affect anything.

jstockwin commented 8 years ago

This is no longer a problem as you can no longer add multiple instances of a film which you have already nominated. If you select multiple films, each is handled in turn, so the first film will be "added", but after that nothing further will happen.

The only slight problem is your veto preference for the last film in the list is the one that will stick, but that's your fault for trying to add a film more than once.