search

jstransformers / jstransformer

Normalize the API of any JSTransformer.
http://npm.im/jstransformer
MIT License
153 stars 12 forks source link

Deprecate/remove Promise #107

Closed RobLoach closed 1 year ago

RobLoach commented 8 years ago

Now that node 4.0.0 is out, it means we are currently supportly three different versions of Node. It would be nice to just target that previous 2 releases. Considering that, I propose we remove http://npm.im/promise and use the native Promise.

tunnckoCore commented 8 years ago

:-1: We should stay with it until April 2017, If understood correctly, when 0.10 will be totally obsoleted. That's why I changed my boilerplate travis file for builds to support only 0.10, 0.12 and 4.

ForbesLindesay commented 8 years ago

I agree with @tunnckoCore. This is definitely something we want to do, but I think this is about 6 months too early.

RobLoach commented 8 years ago

Node 6 is out now, and it has been more than 6 months. Support only Node.js 4, 5, and 6?

TimothyGu commented 8 years ago

We at @pugjs are using jstransformers for Pug 2.0.0, which supports everything from 0.10. It'd be a shame to see a module we use not support the Node.js versions Pug supports, especially when the support requires literally one line of code.

tunnckoCore commented 8 years ago

It'd be a shame to see a module we use not support the Node.js versions Pug supports

:+1:

RobLoach commented 8 years ago

What is your support window? Will it align with Node.js's LTS schedule?

RobLoach commented 7 years ago

We're no longer supporting Node.js 0.10. Node.js 0.12 has native Promise support. We can now safely remove http://npm.im/promise .

A lot of the use of http://npm.im/promise is .nodeify and .denodeify. It is converting a lot of async functions back and forth between Promises/callbacks. We could likely clean some of that up.