jstrausd / homebridge-simple-wled

Homebridge Plugin to control WLED LED-Strips
ISC License
63 stars 17 forks source link

AnthonySimek: Brightness fix + ReadMe.md typo #56

Closed TonnyCS closed 1 year ago

TonnyCS commented 1 year ago

Fixed issue with setting brightness as described in issue #36

TonnyCS commented 1 year ago

The fix added an issue when the user changes color and the brightness value is below 100. The problem was with setting the seg using the RGB values.

I removed the v parameter from the mapper and set it's value to 1 statically.

jstrausd commented 1 year ago

Thanks for contributing to this project. I merged it. But i noticed that the brightness is still not to 100% correct, but for now it's a good fix. Due i have currently really no spare time to further develop this project some features are delayed and i am looking forward for someone to develop some features and contribute them to this project.