search

jstuckey / gulp-gzip

Gzip plugin for gulp.
MIT License
175 stars 17 forks source link

Add a `contentEncoding` property to compressed files. #13

Closed izaakschroeder closed 9 years ago

izaakschroeder commented 9 years ago

This can be used later on by other parts of a pipeline to:

It follows roughly the same semantics as the HTTP 'Content-Encoding' header and allows a consumer of the file to observe all the encoding processes that occurred on the file. See: http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html section 14.11.

izaakschroeder commented 9 years ago

See also: https://github.com/izaakschroeder/vinyl-s3/pull/5

jstuckey commented 9 years ago

Looks good. Thanks for the PR!

Would you mind adding a test to test/test.js?

jstuckey commented 9 years ago

Bah, it looks like some of the test are broken. Not sure how that happened. I'll investigate when I get home tonight.

jstuckey commented 9 years ago

Alright, I fixed the broken tests. Would you mind adding a test for this feature? I'd by happy to merge afterwards.

izaakschroeder commented 9 years ago

Thanks! On it.

izaakschroeder commented 9 years ago

All yours @jstuckey. :tada:

jstuckey commented 9 years ago

Awesome, thanks! :shipit:

jstuckey commented 9 years ago

Published to npm.

izaakschroeder commented 9 years ago

:+1: :gem: