search

jstuckey / gulp-gzip

Gzip plugin for gulp.
MIT License
175 stars 17 forks source link

Remove file.clone() so that upstream file decorations are not lost #5

Closed ngConsulti closed 10 years ago

ngConsulti commented 10 years ago

For example, when gulp-bytediff is used to see the savings from gzip, it attaches a "start value" to the file and looks for it later to calculate the savings. By calling file.clone(), this annotation is lost. All test pass without the overhead and issues involved in cloning the file.

milyord commented 10 years ago

Any word on when this is getting merged? I'm running into some of the same issues with gulp-rev.

KyivJunta commented 10 years ago

Sometimes @jstuckey feedbacks lazily, just wait.

jstuckey commented 10 years ago

I will merge when I get home from work.

@alex4k, it hasn't even been 24 hours since the pull request. People have lives.

KyivJunta commented 10 years ago

@jstuckey don't be angry. ;)

ngConsulti commented 10 years ago

Thank you, @jstuckey. I'll be online most of the evening if you require any adjustments.

milyord commented 10 years ago

Thank you, @jstuckey and @ngConsulti you guys rock.

jstuckey commented 10 years ago

Merged. Thanks, guys.

The file cloning was left over from when gulp had a lot less documentation. Basically, all the example plugins were cloning the file, so I did as well. It doesn't seem to be necessary for this plugin though.