search

jstuckey / gulp-gzip

Gzip plugin for gulp.
MIT License
175 stars 17 forks source link

Only gzip appropriate filetypes, ignore others #9

Closed neilcarpenter closed 9 years ago

jstuckey commented 9 years ago

Hey, thanks for the PR!

It makes me nervous having a hardcoded list of filetypes. There's bound to be filetypes that we missed. What about making this an option instead? Maybe it could be a parameter that contains a list of gzip-able filetypes (similar to the other options shown in the README).

Also, would you mind adding some tests for this feature?

jstuckey commented 9 years ago

After some more thought, I don't think we should include this feature. I think this plugin should just naively compress the files it's passed. A plugin like gulp-if or gulp-grep could be used to limit the file types that reach gulp-gzip.

Let me know if you have any concerns, and thanks again for the PR!